Merge pull request #826 from kernelkit/container-fixes

Container fixes

board/common/rootfs/etc/finit.d/available/container@.conf

@@ -1,4 +1,4 @@
 service :%i pid:!/run/k8s-logger-%i.pid <usr/container:%i> \
 	[2345] k8s-logger -cni %i -f local1 /run/containers/%i.fifo -- Logger for container %i
-sysv    :%i pid:!/run/container:%i.pid <pid/k8s-logger:%i> log kill:10 \
+sysv    :%i pid:!/run/container:%i.pid <!pid/k8s-logger:%i> log kill:10 \
 	[2345] container -n %i -- container %i

board/common/rootfs/etc/profile.d/alias.sh

@@ -1,2 +1 @@
 alias cli='clish'
-alias cfg='sysrepocfg -f json'

board/common/rootfs/usr/bin/cfg

@@ -0,0 +1,58 @@
+#!/bin/sh
+# User-friendly wrapper for sysrepocfg
+# TODO: add import/export, copy, ...
+
+# Edit YANG binary types using sysrepo, base64, and duct tape.
+edit()
+{
+    xpath=$1
+    if [ -z "$xpath" ]; then
+	echo "Usage: cfg edit \"/full/xpath/to/binary/leaf\""
+	exit 1
+    fi
+
+    if tmp=$(sysrepocfg -G "$xpath"); then
+	file=$(mktemp)
+
+	echo "$tmp" | base64 -d > "$file"
+	if /usr/bin/editor "$file"; then
+	    tmp=$(base64 -w0 < "$file")
+	    sysrepocfg -S "$xpath" -u "$tmp"
+	fi
+
+	rm -f "$file"
+    else
+	echo "Failed to retrieve value for $xpath"
+	exit 1
+    fi
+}
+
+usage()
+{
+    echo "Usage:"
+    echo "    cfg CMD [ARG]"
+    echo
+    echo "Command:"
+    echo "    edit XPATH   Edit YANG binary type"
+    echo "    help         This help text"
+    echo
+    echo "As a backwards compatible fallback, this script forwards"
+    echo "all other commands as options to sysrepocfg."
+    echo
+
+    exit 0
+}
+
+cmd=$1; shift
+case $cmd in
+    edit)
+	edit "$1"
+	;;
+    help)
+	usage
+	;;
+    *)
+	set -- "$cmd" "$@"
+	exec sysrepocfg -f json "$@"
+	;;
+esac

board/common/rootfs/usr/lib/tmpfiles.d/frr.conf

@@ -1 +1,2 @@
 d /var/run/frr 0755 frr frr -
+R /var/tmp/frr -    -   -   -

board/common/rootfs/usr/libexec/infix/mnt

@@ -45,11 +45,6 @@ factory_reset()
     find /sys/class/leds/ -type l -exec sh -c 'echo 100 > $0/brightness' {} \;
     logger $opt -p user.crit -t "$nm" "Resetting to factory defaults."
 
-    # Shred all files to prevent restoring contents
-    find /mnt/cfg -type f -exec shred -zu {} \;
-    find /mnt/var -type f -exec shred -zu {} \;
-
-    # Remove any lingering directories and symlinks as well
     rm -rf /mnt/cfg/* /mnt/var/*
 
     logger $opt -p user.crit -t "$nm" "Factory reset complete."