Fix MCP pause case and re-organize drain controller package #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
SchSeba
force-pushed
the
drain_improve
branch
from
90bd6d3
to
b216f97
Compare
Pull Request Test Coverage Report for Build 11935829798Details
💛 - Coveralls |
SchSeba
force-pushed
the
drain_improve
branch
2 times, most recently
from
260e9f5
to
22f6efa
Compare
zeeke
reviewed
Nov 18, 2024
controllers/helper_test.go
Outdated
| @@ -1,330 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
this was related to the device plugin one I rebase this PR
controllers/drain_controller.go
Outdated
| @@ -250,93 +169,17 @@ func (dr *DrainReconcile) getObject(ctx context.Context, req ctrl.Request, objec | |||
| return true, nil | |||
| } | |||
|
|
|||
| func (dr *DrainReconcile) ensureAnnotationExists(ctx context.Context, object client.Object, key string) (string, error) { | |||
| func (dr *DrainReconcile) ensureAnnotationExists(ctx context.Context, object client.Object, key string) (string, bool, error) { | |||
| value, exist := object.GetAnnotations()[key] | |||
| if !exist { | |||
| err := utils.AnnotateObject(ctx, object, constants.NodeStateDrainAnnotationCurrent, constants.DrainIdle, dr.Client) | |||
There was a problem hiding this comment.
this should be
err := utils.AnnotateObject(ctx, object, key, constants.DrainIdle, dr.Client)
right?
Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
drain_improve
branch
from
22f6efa
to
9666ef9
Compare
Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
drain_improve
branch
from
9666ef9
to
8f45dce
Compare
ykulazhenkov
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.