[Remove Default Objs 4/4] Update Webhook #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Related to #592 |
Pull Request Test Coverage Report for Build 7814727136
💛 - Coveralls |
adrianchiris
force-pushed
the
webhook-create-only-default-config
branch
from
98d1dc2
to
828c9db
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
As the operator no longer creates default SriovOperatorConfig and SriovNetworkNodePolicy the webhook is updated in the following Manner: Validating: - Allow deletion of default config/policy. - Block create/update of non default config CR Mutating: - keep skipping default but add a comment to mark as deprecated. Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
webhook-create-only-default-config
branch
from
828c9db
to
b98c804
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
e0ne
requested changes
Feb 7, 2024
e0ne
approved these changes
Feb 7, 2024
ykulazhenkov
approved these changes
Feb 20, 2024
zeeke
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the operator no longer creates default
SriovOperatorConfig and SriovNetworkNodePolicy
the webhook is updated in the following Manner:
Validating:
Mutating:
NOTE for reviewers: should be merged after #622