-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add minio remote cache support in the operator #464
Comments
I would like to take up this issue please, Also I'm new to this operator ecosystem and trying to find my way, |
@arbreezy I am currently working on this feature. I tried to use the S3_cache schema in pkg/client/config.go if config.Spec.RemoteCache.MinIO != nil {
req.Cache = &schemav1.Cache{
CacheType: &schemav1.Cache_S3Cache{
S3Cache: &schemav1.S3Cache{
BucketName: config.Spec.RemoteCache.MinIO.BucketName,
Endpoint: config.Spec.RemoteCache.MinIO.Endpoint,
},
},
}
} But i get this error during reconciliation loop Finished Reconciling k8sGPT with error: failed to call AddConfig RPC: rpc error: code = Unimplemented desc = unknown service schema.v1.ServerConfigService
2024-09-23T11:32:52Z ERROR Reconciler error {"controller": "k8sgpt", "controllerGroup": "core.k8sgpt.ai", "controllerKind": "K8sGPT", "K8sGPT": {"name":"k8sgpt-sample","namespace":"k8sgpt-operator-system"}, "namespace": "k8sgpt-operator-system", "name": "k8sgpt-sample", "reconcileID": "d0a14f69-ad49-4dca-a546-aa83836069d4", "error": "failed to call AddConfig RPC: rpc error: code = Unimplemented desc = unknown service schema.v1.ServerConfigService"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:324
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:226 does this require changing the schema/protobuf ? or changing the server implementation ? @chetak123 I might be able to create a PR soon, you can have a look at changes and suggest improvements. |
Please make sure you pull the latest four SDK's that are part of the RPC stack https://buf.build/k8sgpt-ai/k8sgpt/sdks Follow these instructions to get the generated SDK for k8sgpt-ai/k8sgpt at main using v1.34.2 of protocolbuffers/go.More details on Go SDKs v1.5.1 v1.17.0 v2.22.0 |
Signed-off-by: Shahrooz Aghili <[email protected]>
Signed-off-by: Shahrooz Aghili <[email protected]>
Signed-off-by: Shahrooz Aghili <[email protected]>
Signed-off-by: Shahrooz Aghili <[email protected]>
Checklist
Is this feature request related to a problem?
None
Problem Description
No response
Solution Description
We have recently added Minio as another remote cache storage, to hold K8sGPT's findings.
In order to have feature parity, it will be great to add it in the operator's config as well
Benefits
Feature parity with K8sGPT
Potential Drawbacks
No response
Additional Information
There is already a GRPC proto schema to support minio S3-like api
and the original PR has included the server mode changes
The text was updated successfully, but these errors were encountered: