Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading external metrics to assess Service readiness #1745

Open
infbase opened this issue Oct 2, 2024 · 1 comment
Open

Support reading external metrics to assess Service readiness #1745

infbase opened this issue Oct 2, 2024 · 1 comment

Comments

@infbase
Copy link
Contributor

infbase commented Oct 2, 2024

There are multiple scenarios where it would be useful to look at external metrics to assess service readiness, in addition to the current logic. For instance, by looking at nginx ingress controller metrics, scenarios such as abnormal performance or request count could be identified and the service determined to be unready.

A way to support this would be to add the ability to query Prometheus metrics, for instance somewhat like KEDA's Prometheus scaler does. When designing this implementation, it should be considered if support for Prometheus queries should be directly baked into k8gb or implemented thru an external call, such as:

This implementation should not address single endpoint readiness. That should be done using standard K8s readiness probes even if calling external tools.

@abaguas
Copy link
Collaborator

abaguas commented Nov 10, 2024

KEDA exposes metrics from external sources via the Kubernetes metrics server as custom metrics: https://keda.sh/docs/2.16/operate/metrics-server/

To profit from this ecosystem we could have a metrics server client in K8GB. Then we would need to query only a single API and could benefit from countless integrations.
This repo may have a client that we can use: https://github.com/kubernetes/metrics. I will read up more in the coming days.

abaguas added a commit to abaguas/k8gb that referenced this issue Nov 11, 2024
While investigating how we can add metric based health checks (for k8gb-io#1745) I noticed that we compute health checks twice.
This PR reduces it to a single call.

Signed-off-by: Andre Aguas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants