🚨 Changes

[kuritka]

Changes

• Get rid of CRD , GSLB CR and API
• No status needed
• Simplify reconciliation
• Simplify watchers
• Get rid of init errors when booting app
• significantly reduced reconciliation cycles
• No errors in reconciliation (especially when when deleting ingress)
• WRR support in the ingress
• Metrics, Log is not injected directiy into package. It goes through Reconciler object and is passed to other objects through constructor.
• Reconciliation tests - completely rewritten into the mocks
• Api over ingress. No reason to use client.Get()...
• "k8gb.absa.oss/finalizer" - > "k8gb.io/finalizer"
• ApiGateway support
  would be clearly done by Mapper interface implementation. (Currently we have ingress mapper implememnted, the Gateway + Routes would be another implementation)
• Add CoreDNS LB Service support for Infoblox - here
• Return one Status object via GetStatus() (status Status), containing getHealthStatus, getHealthyRecords. The functions doesn't retrieve any error now. as well as GetStatus(). It returns empty objects instead.
• GetStatus() If Service can't be loaded in getHealthStatus, the record is UNHEALTHY, Before: error was generated commit
• GetStatus() If corev1.Endpoint can't be loaded in getHealthStatus, the record is UNHEALTHY, Before: error was generated
• TCP and UDP digs are separated strategies (brings easier local testing on colima), easy switch between UDP and TCP
• In FO >2 clusters; When Primary cluster is killed, the first alphabetically sorted takes control and IPs only such cluster are returned. When first alphabetical is killed, second alphabetical takes control etc. CoreDNS of all living clusters always return same cluster IP.

missing

• tests
• terratests
• investigate validations of ingress
• cleanup Makefile
• revisit CI/CD pipelines
• Helm changes
• documentation changes (diagrams has changed, documented text has changed)
• Revisit lifecycle, when kill app on secondary cluster (in FO, RR)
• Revisit /chart, deploy, config folders
• Local Playground changes (no GSLB)
• Remove ExternalDNSEndpoint when k8gb POD deleted (minimal ROI, endpoint will be removed togethet with k8gb namespace)

Critical

• approve [RRR] random round robin coredns-crd-plugin#45
• Remove ExternalDNSEndpoint when ingress annotation deleted
• Finalizer - only INFOBLOX

Nice to have

• shorten period for CreateZoneDelegation, make it independent from reconciliation
• Create mapper for DNSEndpoint living in mapper package, move out DNSEndpoint from assistant.
• Three cluster terratests
• Expose validators in depresolver and reuse in Mapper
• Use CRD-plugin@master When deploy-full-local-setup
• Extend primaryGeoTag as ordered list providing order of substitute regions

killer

• Deprecate GSLB CRD k8gb#1018
• [BUG] UnitTests racing  k8gb#942
• Add annotation containing weights for ingress k8gb#933
• [BUG] GSLB is not updated when Ingress has change k8gb#932
• REFACTORING: Use DepResover mock in constroller tests k8gb#923
• Occasional reconciler error k8gb#566
• Implement weighted round robin load balancing strategy k8gb#50
• [BUG] can't drop ingress when created from GSLB
• [BUG] ingress v1, v1beta1 - must be tested
• [BUG] large number of reconciliation cycles, optimize
• [FEATURE] install finalizer only for Infoblox
• k8s version matrix k8gb#1044
• Question: Split Makefile k8gb#878
• [RRR] random round robin coredns-crd-plugin#45

Hits

• Add support for Gateway API k8gb#954

Design Breaks

• Because of cyrcular imports in mocks I must generate ONE redundant mock (ClientMock) into Mapper package
• Mapper.SetReference() function sets *LoopState into Mapper. It breaks design because it exists and beause it is public. It needs to be public because of visibility in the Mocks. On the other hand, you don't need to touch it.
• symlink_slice is symlink from controller utils into terratest utils. I want to avoid duplicates in the code, but at the same time I don't want to create a dependency on a shared package or release k8gb as a shared module. Thanks to symlink I share the code between two uncommitted applications in monorep and I have a single source of truth. It is the only one file that contains functions working with maps and slices.