vf globalpackages exception

[danielkleinert]

• I am using Fish shell version 3.1 or higher.

• I am using Python version 3.8 or higher.

• I have searched the issues (including closed ones) and believe that this is not a duplicate.

• If related to a plugin, I prefixed the issue title with the name of the plugin.

• OS version and name: macOS 15.1 Beta (24B5055e)

• Fish shell version: 3.7.1

• VirtualFish version: 2.5.9

Issue

I've run into the following error.

╰─❯ vf globalpackages
[: Missing argument at index 3
true =
       ^
~/.local/pipx/venvs/virtualfish/lib/python3.12/site-packages/virtualfish/virtual.fish (line 751): 
	    if [ "true" = (command sed -n 's/include-system-site-packages\s=\s\(true\|false\)/\1/p' $VIRTUALFISH_VENV_CONFIG_FILE) ]
	       ^
in function '__vfsupport_globalpackages_toggle'
	called on line 1 of file ~/.local/pipx/venvs/virtualfish/lib/python3.12/site-packages/virtualfish/virtual.fish
in function '__vf_globalpackages'
	called on line 1 of file ~/.local/pipx/venvs/virtualfish/lib/python3.12/site-packages/virtualfish/virtual.fish
in function 'vf' with arguments 'globalpackages'
sed: 1: "pyvenv.cfg": extra characters at the end of p command
Global site packages enabled.

This is the content of my $VIRTUAL_ENV/$VIRTUALFISH_VENV_CONFIG_FILE:

home = /opt/homebrew/Cellar/[email protected]/3.12.6/bin
implementation = CPython
version_info = 3.12.6.final.0
virtualenv = 20.26.6
include-system-site-packages = false
base-prefix = /opt/homebrew/Cellar/[email protected]/3.12.6/Frameworks/Python.framework/Versions/3.12
base-exec-prefix = /opt/homebrew/Cellar/[email protected]/3.12.6/Frameworks/Python.framework/Versions/3.12
base-executable = /opt/homebrew/Cellar/[email protected]/3.12.6/Frameworks/Python.framework/Versions/3.12/bin/python3.12

[danielkleinert]

╰─❯ sed -n 's/include-system-site-packages[[:space:]]= \(false\)/\1/p'  $VIRTUAL_ENV/pyvenv.cfg
false
╰─❯ sed -n 's/include-system-site-packages\s= \(false\)/\1/p'  $VIRTUAL_ENV/pyvenv.cfg

╰─❯ sed -n 's/include-system-site-packages[[:space:]]= \(true\|false\)/\1/p'  $VIRTUAL_ENV/pyvenv.cfg

I do not comprehend. Is sed broken, or am I?

[justinmayer]

I don't think you are the one who is broken, Daniel. I am seeing similar weird behavior with sed.

I didn't write the code in question, but I think I may have fixed it in: adec285

Can you try that and see if it fixes the problem for you?

[danielkleinert]

That did it! Thanks!