Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an option to collapse an embedded iframe #70

Open
jasongrout opened this issue Aug 4, 2022 · 3 comments
Open

Make an option to collapse an embedded iframe #70

jasongrout opened this issue Aug 4, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@jasongrout
Copy link
Collaborator

Problem

An embedded retrolite or jlab iframe is really valuable to have in a docs page as it provides the user an immediate opportunity to interact, but it comes with a heavy download cost that projects may not want to pay, particularly on their front docs page. However, providing only a link to a separate retrolite page may stifle user engagement too much by requiring an extra click and navigation away from the current page.

Proposed Solution

Provide an option for embedded iframes to be initially collapsed with an HTML details element, like this:

<details><summary>Try it now!</summary>[embedded iframe]</details>
Try it now![embedded iframe]

We could even lazily create the iframe with a bit of javascript that listens for the details toggle event, so the initial page load doesn't automatically trigger a heavy download of retrolite.

Additional context

This came up in a discussion in ipyleaflet about whether we should have an embedded retrolite on the front page of the docs (see jupyter-widgets/ipyleaflet#1007 (comment)). The idea of using a details element was suggested by @williamstein when we were discussing putting an embedded retrolite on the front page of the ipywidgets documentation.

@jasongrout jasongrout added the enhancement New feature or request label Aug 4, 2022
@jasongrout
Copy link
Collaborator Author

Ah, I see lazy loading was introduced in #67 in a very nice way! So this issue is more about providing a way to not take up the vertical space for an inactive retrolite.

@martinRenou
Copy link
Member

Thank you for the suggestion!

Maybe this could be added behind a collapsible directive option? And we could use the prompt option for the details summary.

@jasongrout jasongrout changed the title Make an option to collapse an embedded iframe and maybe lazy load it Make an option to collapse an embedded iframe Aug 17, 2022
@agriyakhetarpal
Copy link
Collaborator

agriyakhetarpal commented May 13, 2024

Not sure if this helps, and I might also be trying to breathe life into a discussion that's already quite old, but at least for the making-things-collapsible aspect, I managed to wrap the directive with a dropdown directive with the sphinx-design Sphinx extension which I think is really neat. It can be tried out here:

https://pywavelets--741.org.readthedocs.build/en/741/regression/wavelet.html

xref: PyWavelets/pywt#741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants