Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on python 3.12 #978

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Test on python 3.12 #978

merged 3 commits into from
Oct 10, 2023

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073 blink1073 merged commit 7404439 into jupyter:main Oct 10, 2023
29 checks passed
@blink1073 blink1073 deleted the test-py312 branch October 10, 2023 16:08
@tornaria
Copy link

Let me point out that this is actually failing exactly as I reported in #979.

Indeed, check out: https://github.com/jupyter/jupyter_client/actions/runs/6463461968/job/17571024062?pr=978#step:4:679

Your workflow is actually ignoring the check failure, but it is there in the log.

@blink1073
Copy link
Contributor Author

We're not ignoring it, we're retrying. The event loop situation is not ideal, but we are doing our best.

@tornaria
Copy link

We're not ignoring it, we're retrying. The event loop situation is not ideal, but we are doing our best.

Sure. I was just trying to be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants