Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include redundant links when calculate collision #232

Merged
merged 1 commit into from
Sep 13, 2016

Conversation

chiwunau
Copy link
Contributor

@chiwunau chiwunau commented Jun 14, 2016

This is to fix the problem discussed in #206

@k-okada
Copy link
Member

k-okada commented Jun 15, 2016

@h-kamada please check if this PR is OK for you.

@h-kamada
Copy link
Contributor

The code itself seems ok.

I faced the collision problem when I was writing about :start-grasp , stop-grasp method of *pr2*.
Currently :start-grasp is checking grasp by checking collisions of all gripper links. ( --> https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus/pr2-utils.l#L263-L272)

I forgot details about this , but I think the problem was that pqp-collision-check didn't work well if I used (pqp-collision-check *pr2* target).
So I tried to check whether I can use (pqp-collision-check *pr2* target) if I use this code.
But the original code also worked well (not knowing why).
So I couldn't check whether this code is ok for my problem.

@chiwunau
Copy link
Contributor Author

chiwunau commented Jun 15, 2016

In this PR (I and not quite sure about what is actually done behind, in GL level and there might be better solution),
collision models are basically attached to their ascendant link found in eus model link-list, so in this case gripper links are considered as wrist_roll_link.
which means (pqp-collision-check (elt (send *pr2* :larm :links) 6) cube) returns 1 in the picture below.
I also tested when gripper is open and it returns also 1, I guess it is because all gripper links are calculate as a single static solid object.
So the original code may be needed to specify only gripper tip links.
screenshot_from_2016-06-15 19 24 39

@k-okada
Copy link
Member

k-okada commented Jun 22, 2016

@snozawa , @YoheiKakiuchi could take a look at this PR and check if we can import this code into irteus level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants