Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Non-Standard Charset Name #20

Open
s25g5d4 opened this issue Dec 21, 2017 · 1 comment
Open

Allow for Non-Standard Charset Name #20

s25g5d4 opened this issue Dec 21, 2017 · 1 comment
Assignees

Comments

@s25g5d4
Copy link

s25g5d4 commented Dec 21, 2017

Hello,

I encountered a server that returns content-disposition: attachment; filename="file.png"; filename*=utf8''file.png which is, according to RFC 5987, malformed because the charset should be utf-8, rather than utf8. When trying to decode content-disposition, it will fail at

throw new TypeError('unsupported charset in extended field')
. It is not my server and I have no way to ask them to change, so if you can fix this (either by accept utf8 or fallback to filename) that would be appreciated.

@dougwilson
Copy link
Contributor

Yea, I agree that there needs to be at least one of those options (the very minimum to be able to ignore the unknown encoding because there wasn't a parse error, it parsed fine but just didn't know how to decode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants