Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win.close() or win.hide() #15

Open
fkoji opened this issue Jun 27, 2011 · 1 comment
Open

win.close() or win.hide() #15

fkoji opened this issue Jun 27, 2011 · 1 comment

Comments

@fkoji
Copy link

fkoji commented Jun 27, 2011

Thank you for your great library. But I have one problem.

After OAuth flow or cancel OAuth, my app doesn't accept any operation.
When show_login_toolbar option is true, the toolbar remains on screen after OAuth window has closed.

I think this problem is caused by win.close();

- win.close();
+ win.hide();

win.hide() is better. oauth-adapter also uses window.hide().

@jpurcell
Copy link
Owner

Interesting. It would be nice if Titanium's docs explained more of the diff between close() and hide(). My guess is that it is the obvious:
http://stackoverflow.com/questions/6245803/what-does-window-close-do-to-the-contents-of-said-window/6313554#6313554
The former removes the window and the latter leaves the window but hides it. It's not apparent why hide() would work better than close(). Nonetheless, thanks for the tip--I'll but sure to look into this for 1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants