This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Fix PHP asciiToShortnameCallback (called on ASCII to shortname conversion) #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHP function asciiToShortnameCallback replacement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting ASCII smileys using asciiToShortname, asciiToShortnameCallback is called. This function executes array_flip(array_reverse($ruleset->getShortcodeReplace())); that always results in an empty array, replacing ASCII smileys with empty strings.
Also, function should return shortnames for smileys and not their unicode equivalents, therefore only $ascii_replace is needed.