Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML language attribute does not get updated on multilingual pages #1100

Open
drjjw opened this issue Sep 14, 2020 · 2 comments
Open

HTML language attribute does not get updated on multilingual pages #1100

drjjw opened this issue Sep 14, 2020 · 2 comments

Comments

@drjjw
Copy link

drjjw commented Sep 14, 2020

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

Multilingual site required. HTML language attribute will only get added for the default language and does not change on other langages.

Expected result

Eg:

<html lang="en-gb" dir="ltr">

Should become on french version of same page:

<html lang="fr-fr" dir="ltr">

but does not

Actual result

Eg:

<html lang="en-gb" dir="ltr">

remains

<html lang="en-gb" dir="ltr">

System information (as much as possible)

Joomla! 3.9.21
Tested in PHP 7.4

Additional comments

Can be fixed by changing index.php of template from:

<html lang="<?php echo $this->language; ?>" dir="<?php echo $this->direction; ?>">

to:

<html lang="<?php echo $_REQUEST['language'];?>" dir="<?= $this->direction ?>"

@richard67
Copy link
Member

@drjjw Did you notice the first line in the issue template when filling out this issue?

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

To me it seems this is exactly the case. Your issue reads to me as if it was for the CMS.

If this is the case, please do as advised. Use the link to create the issue: https://github.com/joomla/joomla-cms/issues/new.

Thanks in advance.

@richard67
Copy link
Member

@drjjw P.S. And after having created the issue at the right place, close it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants