Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename everything to class_*? #61

Open
jonthegeek opened this issue Oct 5, 2023 · 0 comments
Open

Rename everything to class_*? #61

jonthegeek opened this issue Oct 5, 2023 · 0 comments

Comments

@jonthegeek
Copy link
Owner

Eventually this package will (I think?) have functions for accessing, using, and manipulating rapid objects. Should I rename the constructors to (for example) class_rapid() (etc)? If so, should the class remain the simpler name (probably), in which case they'd look something like this:

class_rapid <- S7::new_class(
  "rapid",
  package = "rapid",
  properties = list(
    info = info,
    servers = servers,
    components = component_collection,
    security = security_requirements
  ) ...

This will help separate property names from class constructor names, which avoids RConsortium/S7#373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant