Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter #35

Merged
merged 19 commits into from
Sep 8, 2023
Merged

Smarter #35

merged 19 commits into from
Sep 8, 2023

Conversation

jonthegeek
Copy link
Owner

Closes #34.
Closes #33.
Closes #30.

The regex doesn't actually work, and these urls can be non-standard. We don't really care about these until we're using them, let's let people do weird things here.
And distribute TODOs.
Closes #30.

This is the only place that variables() appears in the definition, and there's really no reason that it would have to be server-specific anyway.
I couldn't stick with the OpenAPI names. This makes much more sense to me. More to come in this area.
This is a list of "string_replacements" objects, which are themselves lists. I want to make sure these stand out as special for a multi-server-with-different-variables situation.
@jonthegeek jonthegeek enabled auto-merge (squash) September 8, 2023 21:01
@jonthegeek jonthegeek merged commit dee4067 into main Sep 8, 2023
6 of 7 checks passed
@jonthegeek jonthegeek deleted the smarter branch September 8, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as.list() Show all errors server_variable_list: smarter?
1 participant