Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements #143

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Minor enhancements #143

merged 2 commits into from
Feb 1, 2024

Conversation

maroskukan
Copy link
Contributor

Hello, thanks for this tool,

I would like to propose the following changes/enhancements:

docs/examples/docker/README.md

  • added working directory to "medusa" function - this makes the volume mount more useful as the paths inside and outside of containers are same. Its now easy to reference a file on host and use it inside the container e.g. import files
  • added example for medusa import when invoked through docker container

scripts/start-vault.sh

  • update the image path to hashicorp/vault:latest for "Vault status" invocation
  • add .env file generation, which is useful when using docker container which maps these values between host and container. user is still required to source this env file . ./.env or use some tool that does it automatically
  • backup existing configuration file for medusa if present - saves from accidental overwrite of previous configuration

@jonasvinther jonasvinther merged commit 5ed081e into jonasvinther:main Feb 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants