Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this package dead ? no update since 2 years #507

Open
alainib opened this issue Jun 17, 2024 · 8 comments
Open

is this package dead ? no update since 2 years #507

alainib opened this issue Jun 17, 2024 · 8 comments

Comments

@alainib
Copy link

alainib commented Jun 17, 2024

Describe the bug
A clear and concise description of what the bug is.

Reproduce

  • Create a demo on https://snack.expo.io to reproduce the issue.
  • Add gif screenshots to help explain your issue.

Dependencies:

  • react-native-modalize [e.g. 1.3.7-rc.19]
  • react-native [e.g. 0.62.0]
  • react-native-gesture-handler [e.g. 1.6.0]
  • expo/react-navigation/react-native-navigation: [e.g. [email protected]]
@Kayre-Scott-Primon
Copy link

Anyone has any suggest of the lib for a bottom sheet modal in React Native?

@alainib
Copy link
Author

alainib commented Jul 10, 2024

Anyone has any suggest of the lib for a bottom sheet modal in React Native?

hello @Kayre-Scott-Primon i tried gorhom lib.
https://github.com/gorhom/react-native-bottom-sheet

it work smooth but i was never able to compile my code in release mode anymore because of reanimated. tryed like 2 days to solve this but cannot. gorhom/react-native-bottom-sheet#1824

i guess i have to retry now or to get the code of this lib and fix it alone

if you manage to make this with reactnative +0,74 please tell me which version of reanimated and bottom-sheet you used.

@Kayre-Scott-Primon
Copy link

Hi @alainib, instresting!
I guess i will use react-native-bottom-sheet or i will create by my self.
If i will use react-native-bottom-sheet and i get to run code in release mode, i'll tell here.
Thanks a lot!

@bestoferanda
Copy link

Anyone has any suggest of the lib for a bottom sheet modal in React Native?

hello @Kayre-Scott-Primon i tried gorhom lib. https://github.com/gorhom/react-native-bottom-sheet

it work smooth but i was never able to compile my code in release mode anymore because of reanimated. tryed like 2 days to solve this but cannot. gorhom/react-native-bottom-sheet#1824

i guess i have to retry now or to get the code of this lib and fix it alone

if you manage to make this with reactnative +0,74 please tell me which version of reanimated and bottom-sheet you used.

same for me
any update on this ? did u able to fix that ?

@alainib
Copy link
Author

alainib commented Aug 23, 2024

Anyone has any suggest of the lib for a bottom sheet modal in React Native?

hello @Kayre-Scott-Primon i tried gorhom lib. https://github.com/gorhom/react-native-bottom-sheet
it work smooth but i was never able to compile my code in release mode anymore because of reanimated. tryed like 2 days to solve this but cannot. gorhom/react-native-bottom-sheet#1824
i guess i have to retry now or to get the code of this lib and fix it alone
if you manage to make this with reactnative +0,74 please tell me which version of reanimated and bottom-sheet you used.

same for me any update on this ? did u able to fix that ?

i use modalize in production but some features don't work 100%

never been able to compile with gorhom/react-native-bottom-sheet ( didn't try since 2 months )

@fekajin
Copy link

fekajin commented Nov 12, 2024

Anyone has any suggest of the lib for a bottom sheet modal in React Native?

hello @Kayre-Scott-Primon i tried gorhom lib. https://github.com/gorhom/react-native-bottom-sheet
it work smooth but i was never able to compile my code in release mode anymore because of reanimated. tryed like 2 days to solve this but cannot. gorhom/react-native-bottom-sheet#1824
i guess i have to retry now or to get the code of this lib and fix it alone
if you manage to make this with reactnative +0,74 please tell me which version of reanimated and bottom-sheet you used.

same for me any update on this ? did u able to fix that ?

i use modalize in production but some features don't work 100%

never been able to compile with gorhom/react-native-bottom-sheet ( didn't try since 2 months )

In order to compile react-native-bottom-sheet v5, you need to implement the changes of latest gesture handler and reanimated:
https://docs.swmansion.com/react-native-gesture-handler/docs/fundamentals/installation/
https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/getting-started/

import { GestureHandlerRootView } from 'react-native-gesture-handler';

export default function App() {
  return (
    <GestureHandlerRootView style={{ flex: 1 }}>
      {/* content */}
    </GestureHandlerRootView>
  );
}

Is the problem continues after implementing these changes?

@alainib
Copy link
Author

alainib commented Nov 13, 2024

Anyone has any suggest of the lib for a bottom sheet modal in React Native?

hello @Kayre-Scott-Primon i tried gorhom lib. https://github.com/gorhom/react-native-bottom-sheet
it work smooth but i was never able to compile my code in release mode anymore because of reanimated. tryed like 2 days to solve this but cannot. gorhom/react-native-bottom-sheet#1824
i guess i have to retry now or to get the code of this lib and fix it alone
if you manage to make this with reactnative +0,74 please tell me which version of reanimated and bottom-sheet you used.

same for me any update on this ? did u able to fix that ?

i use modalize in production but some features don't work 100%
never been able to compile with gorhom/react-native-bottom-sheet ( didn't try since 2 months )

In order to compile react-native-bottom-sheet v5, you need to implement the changes of latest gesture handler and reanimated: https://docs.swmansion.com/react-native-gesture-handler/docs/fundamentals/installation/ https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/getting-started/

import { GestureHandlerRootView } from 'react-native-gesture-handler';

export default function App() {
  return (
    <GestureHandlerRootView style={{ flex: 1 }}>
      {/* content */}
    </GestureHandlerRootView>
  );
}

Is the problem continues after implementing these changes?

thanks for tips :)

yes even with this it crash in release mode ( it work in dev mode )
i guess i have to try with latest version maybe

@Grilldrengen
Copy link

Grilldrengen commented Nov 20, 2024

We had issues once because on Iphone you could change how much animation was allowed. This affected the bottomsheet, so it closed instantly after openning and therefore could never be accessed. I don't know if this is the issue you are experiencing as it only happens if the user on the phone has enabled reduced motion in accessibility settings. It is also only an issue on Iphone.

import { useReducedMotion } from 'react-native-reanimated';
const reducedMotion = useReducedMotion();

<BottomSheetModal animateOnMount={!reducedMotion} <- Then add it here on the bottom sheet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants