Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for an explicit dep on Hamcrest #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 6, 2024

#222 (review) #223 Normally included in all plugins via jenkins-test-harness, and in this case also via awaitility.

@jglick jglick requested a review from a team as a code owner August 6, 2024 17:58
@jglick jglick added the internal label Aug 6, 2024
@jglick jglick enabled auto-merge August 6, 2024 17:58
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as it is used it directly it should have an explicit dep and not rely on any transitive dependency.

as such this seems incorrect to me.

@jglick
Copy link
Member Author

jglick commented Aug 6, 2024

as it is used it directly it should have an explicit dep

Perhaps, but the same could be said of 90% of Jenkins plugins, and this is the only one I am familiar with which declares the dep explicitly. (As of your #152, apparently.) Unless you propose to activate the Enforcer rule which would mandate use of explicit dependencies, this seems like a gratuitous inconsistency.

Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree for matter of consistency.

@jglick jglick requested a review from a team August 30, 2024 13:52
@jglick jglick requested a review from jtnord November 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants