Add Now Playing to Title Bar #6312
Conversation
Cloudflare Pages deployment
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -527,7 +527,7 @@ | |||
|
|
|||
| function updateNowPlayingInfo(state) { | |||
| const nowPlayingItem = state.NowPlayingItem; | |||
|
|
|||
| var documentTitle = "Jellyfin"; | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead. no-var
Fix available:
| var documentTitle = "Jellyfin"; | |
| let documentTitle = "Jellyfin"; |
| @@ -527,7 +527,7 @@ | |||
|
|
|||
| function updateNowPlayingInfo(state) { | |||
| const nowPlayingItem = state.NowPlayingItem; | |||
|
|
|||
| var documentTitle = "Jellyfin"; | |||
There was a problem hiding this comment.
Strings must use singlequote. @stylistic/quotes
Fix available:
| var documentTitle = "Jellyfin"; | |
| var documentTitle = 'Jellyfin'; |
| secondaryText.appendChild(text); | ||
| } | ||
| } | ||
|
|
||
| if (textLines[0].text) { | ||
| const text = document.createElement('a'); | ||
| text.innerText = textLines[0].text; | ||
| if(documentTitle != "Jellyfin"){ |
There was a problem hiding this comment.
Expected space(s) after "if". @stylistic/keyword-spacing
Fix available:
| if(documentTitle != "Jellyfin"){ | |
| if (documentTitle != "Jellyfin"){ |
| secondaryText.appendChild(text); | ||
| } | ||
| } | ||
|
|
||
| if (textLines[0].text) { | ||
| const text = document.createElement('a'); | ||
| text.innerText = textLines[0].text; | ||
| if(documentTitle != "Jellyfin"){ |
There was a problem hiding this comment.
Strings must use singlequote. @stylistic/quotes
Fix available:
| if(documentTitle != "Jellyfin"){ | |
| if(documentTitle != 'Jellyfin'){ |
| secondaryText.appendChild(text); | ||
| } | ||
| } | ||
|
|
||
| if (textLines[0].text) { | ||
| const text = document.createElement('a'); | ||
| text.innerText = textLines[0].text; | ||
| if(documentTitle != "Jellyfin"){ |
There was a problem hiding this comment.
Missing space before opening brace. @stylistic/space-before-blocks
Fix available:
| if(documentTitle != "Jellyfin"){ | |
| if(documentTitle != "Jellyfin") { |
| secondaryText.appendChild(text); | ||
| } | ||
| } | ||
|
|
||
| if (textLines[0].text) { | ||
| const text = document.createElement('a'); | ||
| text.innerText = textLines[0].text; | ||
| if(documentTitle != "Jellyfin"){ | ||
| documentTitle +=' - '; |
There was a problem hiding this comment.
Operator '+=' must be spaced. @stylistic/space-infix-ops
Fix available:
| documentTitle +=' - '; | |
| documentTitle += ' - '; |
Changes
Add currently playing media to Title Bar
Issues
Resolves #6301