Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add media type specific translation in up next dialog #6307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −5
Open

add media type specific translation in up next dialog #6307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39cec9a
allow dedicated translation of all video types
bluemoehre Nov 8, 2024
a50dd30
fix linter issue
bluemoehre Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/upnextdialog/upnextdialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,16 @@ function setNextVideoText() {

const timeText = '<span class="upNextDialog-countdownText">' + globalize.translate('HeaderSecondsValue', secondsRemaining) + '</span>';

const nextVideoText = instance.showStaticNextText ?
globalize.translate('HeaderNextItem', globalize.translate(instance.itemType)) :
globalize.translate('HeaderNextItemPlayingInValue', globalize.translate(instance.itemType), timeText);
let nextVideoText;
if (instance.itemType === 'Episode') {
nextVideoText = instance.showStaticNextText ?
globalize.translate('HeaderNextEpisode') :
globalize.translate('HeaderNextEpisodePlayingInValue', timeText);
} else {
nextVideoText = instance.showStaticNextText ?
globalize.translate('HeaderNextVideo') :
globalize.translate('HeaderNextVideoPlayingInValue', timeText);
}

elem.querySelector('.upNextDialog-nextVideoText').innerHTML = nextVideoText;
}
Expand Down
6 changes: 4 additions & 2 deletions src/strings/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,10 @@
"HeaderNewDevices": "New Devices",
"HeaderNewPlaylist": "New Playlist",
"HeaderNewRepository": "New Repository",
"HeaderNextItem": "Next {0}",
"HeaderNextItemPlayingInValue": "Next {0} Playing in {1}",
"HeaderNextEpisode": "Next Episode",
"HeaderNextEpisodePlayingInValue": "Next Episode Playing in {0}",
"HeaderNextVideo": "Next Video",
"HeaderNextVideoPlayingInValue": "Next Video Playing in {0}",
"HeaderNoLyrics": "No lyrics found",
"HeaderOnNow": "On Now",
"HeaderOtherItems": "Other Items",
Expand Down
Loading