Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation error for "next episode" prompt #6270

Open
Snipy2k4 opened this issue Oct 30, 2024 · 10 comments
Open

Translation error for "next episode" prompt #6270

Snipy2k4 opened this issue Oct 30, 2024 · 10 comments
Labels
bug Something isn't working i18n This PR or issue mainly concerns internationalization

Comments

@Snipy2k4
Copy link

Snipy2k4 commented Oct 30, 2024

Hello,

Since the latest update 10.10.0, a spelling error is displayed in the browser and on LG devices with the LG app (presumably all devices with browser player) for series or when a new episode starts, in the small window just before the episode.

Normally it says “Next episode”, but now it says “Next/s”.

This makes no sense in German. That's the plural in German. “Nächster/s” episode does not exist, and with an /s after it.

Obviously a translation error.

See screenshot:
mstsc_TWcUJUTqQM

@dmitrylyzo dmitrylyzo transferred this issue from jellyfin/jellyfin-webos Oct 30, 2024
@854562
Copy link
Contributor

854562 commented Oct 30, 2024

As for the translation error, this is caused by a string change in #5666. In this PR, the source string was changed from "Next Episode Playing in" to "Next {0} Playing in" in which {0} is another, separate string representing the type of video that follows. This is bad practice as it causes translation issues like the one you describe, since the grammatical gender and number of {0}, and therefore the correct form of "Next", are unknown. It should be reverted to separate strings for each video type.

It also causes a translation problem in languages that Do Not Use Title Case, making "Next Episode playing in 27 seconds" look out of place, as it should be "Next episode...".

Your other issue is completely unrelated and should therefore be separate.

@Snipy2k4
Copy link
Author

Hello,

I know that the other problem has nothing to do with this, but it is a problem and I thought I would mention it here again as my old ticket has still not been answered.

Because of the translation error, what exactly is happening now? Or do I have to take action here?

@854562
Copy link
Contributor

854562 commented Oct 30, 2024

What (probably) happened is that the German translator saw "Next {0}" and translated it "Nächster/s" because in theory either "Nächste", "Nächster", or "Nächstes" could be correct, depending on the value of {0}. (My knowledge of German is rather basic, so forgive me if that's inaccurate). While to the unassuming eye it might look like an error in the German translation (and could simply be fixed on Weblate), it is actually an inadequacy in the English source string, as it does not account for languages in which adjectives can change depending on the noun they pertain to. (And languages which use sentence case for dialogues like this.)

I would personally edit the title and body of this issue so that it focuses on one single problem. And then we wait for someone to, hopefully, fix it 😃

@Snipy2k4
Copy link
Author

okay. Is this still marked as a bug?

@viown viown added the bug Something isn't working label Oct 31, 2024
@thornbill thornbill changed the title Bugs 10.10.0 - subs, "next episode" and translation error Translation error for "next episode" prompt Nov 4, 2024
@thornbill thornbill added the i18n This PR or issue mainly concerns internationalization label Nov 4, 2024
@bluemoehre
Copy link
Contributor

I can confirm that several languages genderize nouns - so the introduced change of #5666 won't work out to generalize / simplify the translations. Unfortunately we need a translation per each combination:

  • Next Episode
  • Next Video
  • Next whatever ...

@Snipy2k4
Copy link
Author

Snipy2k4 commented Nov 8, 2024

Okay, that was never a problem before, but it was good. You'll manage.

@bluemoehre
Copy link
Contributor

I assume we will add more content types in the future like eg. "Next Song", "Next Season", etc. Therefore it makes sense to have a translation for each type. The code part should then get adapted later on, since it uses terms like setNextVideoText().

As a general rule for translations:
You never know the grammar of a language. So you should never use variables for single words, especially not for combos like this one. Always go with full sentences.

@Snipy2k4
Copy link
Author

Version 10.10.2 has fixed it. Thank you

@854562
Copy link
Contributor

854562 commented Nov 18, 2024

To clear up any potential confusion: someone might have changed the German translation to make it less glaring, but the fix for the actual problem (in the source string) has not been merged yet. Please keep this issue open.

@Snipy2k4
Copy link
Author

Oh, okay. My mistake. Visually it looked like that in the current version 10.10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working i18n This PR or issue mainly concerns internationalization
Projects
None yet
Development

No branches or pull requests

5 participants