Viewport dimensions passed to selenoid #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2024 14:57
ivnglkv
reviewed
Aug 7, 2024
| """Returns visibility status of all elements in the page | ||
|
|
||
| Returned dictionary uses elements' jdn-hash property value as keys | ||
| """ | ||
| escaped_page_content = str(page_content).encode('utf-8').decode('unicode_escape') | ||
|
|
||
| driver = get_webdriver() | ||
| driver.set_window_size(viewport['width'], viewport['height']) |
There was a problem hiding this comment.
I'm afraid window and viewport sizes are different. Viewport is just where page is rendered and window size includes toolbars/scrollbars if I'm not mistaken. I'd like to find a way to make it more precise
There was a problem hiding this comment.
Do you mean to calculate the entire window size, that will support desired size of the viewport?
ivnglkv
approved these changes
Aug 12, 2024
|
Not merging until plugin adopts this API change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.