support Spring annotations for JSF and CDI managed beans #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2022 11:10
Signed-off-by: Thies Wellpott <[email protected]>
Signed-off-by: Thies Wellpott <[email protected]>
jeffmaury
requested changes
May 30, 2022
There was a problem hiding this comment.
Framework specific processing is located in a separate plugin/feature so that main code does not look like spaghetti code and user could not install it.
See
- https://github.com/jbosstools/jbosstools-javaee/tree/main/cdi/plugins/org.jboss.tools.cdi.microprofile.core and https://github.com/jbosstools/jbosstools-javaee/tree/main/cdi/features/org.jboss.tools.cdi.microprofile.feature
- https://github.com/jbosstools/jbosstools-javaee/tree/main/jsf/plugins/org.jboss.tools.jsf.text.ext.richfaces and https://github.com/jbosstools/jbosstools-javaee/tree/main/jsf/features/org.jboss.tools.richfaces.feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added missing "@OverRide" and removed some trailing spaces
used diamond operator (breaks compatibility with Java 6 if still required)