Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passport 0.6.0 regenerates session IDs, breaking custom logins #1009

Open
JohanRonstrom opened this issue Oct 27, 2023 · 0 comments
Open

Passport 0.6.0 regenerates session IDs, breaking custom logins #1009

JohanRonstrom opened this issue Oct 27, 2023 · 0 comments

Comments

@JohanRonstrom
Copy link

JohanRonstrom commented Oct 27, 2023

The new behavior of always regenerating session ID on login described here and implemented here is breaking our application.

We have been using a custom login flow for social login in our desktop application that involves opening a webview, passing along the session ID, setting the session ID in the browser, performing a social login and then killing the webview. This sets the session as logged in to the user in the desktop program.

The new behavior sets the login to a new session ID with a set-cookie, that cannot safely be communicated back to our program, thus making this security update less secure for us.

Adressing session fixation is a good, but for our case we'd really like an option to turn auto-regeneration off for specific cases. We solved the issue for now by pinning the previous version.

Thank you for providing passport, we have been using it in production for 10+ years :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant