Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site push only pumps the version at the end of the script #132

Open
hems opened this issue Mar 21, 2014 · 2 comments
Open

Site push only pumps the version at the end of the script #132

hems opened this issue Mar 21, 2014 · 2 comments
Assignees

Comments

@hems
Copy link
Member

hems commented Mar 21, 2014

The problem is then when the script is building it shows "building version 30" but at the end the sitepush will push 31, so perhaps if sitepush flag is set to "true" we should show the pumped version at the beginning of the script.

@hems hems self-assigned this Mar 21, 2014
@lossius
Copy link
Member

lossius commented May 8, 2014

My bet is that the best would be to up the version number at the beginning of the build, rather than at the end?

I'm also fine with these tags being set at the beginning, even if that means that two pushes close in time might cause the first of the versions to never materialise as an installer. After all I would asume that the reason for the new push would be that something is missing or wrong about the first one.

@hems
Copy link
Member Author

hems commented May 12, 2014

yeah that makes sense !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants