Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVP Review #1 - User auth #4

Open
9 of 10 tasks
aracpyon opened this issue Jan 21, 2021 · 6 comments
Open
9 of 10 tasks

MVP Review #1 - User auth #4

aracpyon opened this issue Jan 21, 2021 · 6 comments

Comments

@aracpyon
Copy link
Collaborator

aracpyon commented Jan 21, 2021 •
edited by jamhanpar
Loading

  • Add favicon
  • Image ratio should not change when you change the size of browser.
  • When you hover, the input border line is grey and when you click the border should be green.
  • When you hover, the colored border is adding an extra space to the form. The form is moving whenever I hover over.
  • The signup and log in page should look different. (Login page has an image and signup page has the session form on the left side with grey block on the right side)
  • Finish signup css based on Robinhood's signup page
  • You need first name and last name on the sign up form
  • Sign up page should print the error messages.
  • Login page should print error messages
  • user auth session is not working
@jamhanpar
Copy link
Owner

jamhanpar commented Jan 22, 2021 •
edited
Loading

  • add demo user

@jamhanpar
Copy link
Owner

jamhanpar commented Jan 22, 2021 •
edited
Loading

  • add errors messages to signup page

@jamhanpar
Copy link
Owner

jamhanpar commented Jan 22, 2021 •
edited
Loading

  • Update error message format in signup page

@aracpyon
Copy link
Collaborator Author

aracpyon commented Jan 23, 2021 •
edited by jamhanpar
Loading

  • remove blue highlight on the continue button when it's clicked.
  • give an animation effect to the input boundaries when hovered. You can use transition css
  • Error messages are persisting through the pages (This means that the error messages are not being cleared)
  • Reduce the space inside the input in the login page
  • mouse to pointer
  • add hovering effect on buttons

@jamhanpar
Copy link
Owner

jamhanpar commented Jan 23, 2021 •
edited
Loading

  • only show signup errors that are relevant
  • highly input elements that are invalid

@aracpyon
Copy link
Collaborator Author

aracpyon commented Jan 25, 2021 •
edited by jamhanpar
Loading

  • (signup) Change the borderlines red when there are error messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamhanpar @aracpyon