Add java types to VarType and type checks to MatParam #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good idea. I'm curious why the checks are enabled dynamically. |
|
While not ideal, i suspect there might be some community code that sets wrong types or changes VarType at runtime (being it protected not final), since this (even if wrong) would technically work in some circumstances, i wanted to provide a way to disable the type check without requiring a recompilation of the engine in case this causes existing code to break. It might be superfluous ... i am not sure |
bob0bob
added a commit
to bob0bob/jmonkeyengine
that referenced
this pull request
May 31, 2023
* Android: Implemented AndroidNativeBufferAllocator - Deprecated AndroidBufferAllocator (jMonkeyEngine#1821) * [skip ci] update natives snapshot * Add GL debug capabilities (jMonkeyEngine#1790) * Add GL debug capabilities * Fix: check for null names * Add java types to VarType and type checks to MatParam (jMonkeyEngine#1797) * SettingsDialog: Fixed LAF * SettingsDialog: Updated jme3 copyright * README.md: add a link to Chatter Games website * Update README.md to include Exotic Matter (jMonkeyEngine#1838) Would be great to have our game Exotic Matter also mentioned as its engine is based on jME. Thanks! * jme3-examples: update the fallback URLs for "TerrainGridTestData.zip" * Improved code readability: ParticlePointMesh and ParticleTriMesh (jMonkeyEngine#1831) * jme3-core: add tests for Transform.toString() * Fix issue jMonkeyEngine#1839 (Memory Leak in DefaultLightFilter) Co-authored-by: Lukas Habring <lukas@Lukas-PC> * Added getter & setter for FilterPostProcessor.depthFormat (jMonkeyEngine#1841) * Added setter for FilterPostProcessor.depthFormat * Added getter for FilterPostProcessor.depthFormat * update the Gradle wrapper to v7.5.1 * main.yml: GitHub Action's ubuntu-18.04 environment is deprecated * bugfix: mergedJavadoc task is incompatible with Gradle v7 * main.yml: udate "actions/setup-java" to v3 * main.yml: add JDK 17 tests * build.gradle: update gradleVersion in case user runs the "wrapper" task * Fix jMonkeyEngine#1843 (java.util.zip.ZipException in HttpZipLocator) (jMonkeyEngine#1842) * HttpZipLocator:fix invalid code lengths set & invalid distance too far back ZipExceptions. * Get file name length and extra field length from local file header to calculate file data offset. * Make fields `byteBuf`, `charBuf`, `utf8Decoder` non-static because they are not thread-safe. * Surround streams with try-with-resources block. * Clean up the display modes parsing * No need to separately test for the contains * README.md: SDK v3.4 has been released * Some enhancement to new animation system (jMonkeyEngine#1845) * Some enhancement to new animation system, including: * Option to enable/disable animation mask propagation to child actions. * Option to control max transition weight. For example useful for controlling smooth animation transition when an animation is removed from an upper layer. * Added animation loop support in AnimLayer. * AnimLayer can now also keep action name, so one can easily lookup currently playing action name in an specific layer. * Minor Javadoc fix. * AnimLayer: clear `currentActionName` inside `cloneFields` method. * Added a Loop tween to Tweens factory class (jMonkeyEngine#1846) * Added a Loop tween to Tweens factory class. Supports looping by count or duration. * Redesigned the Loop tween to work similar to Sequence tween. Now fast forwarding the loop will also try to catch up the loops left behind making sure they always see their 'length'. * Added the missing Override annotation. * Added Tweens.cycle() and Tweens.invert() methods (jMonkeyEngine#1849) Cycle is used for running delegate tween back and force and Invert is used to run delegate tween backward. * BlendAction: resolve slow-motion side effect caused by stretching actions (jMonkeyEngine#1848) * BlendAction: resolve slow motion side effect caused by stretching any action that doesn't have the same length. It generates speed factor for each child animation that are dynamically interpolated and applied to base speed based on the blend weight taken from blend space. * Add missing javadoc. * Add Copyright. * Renamed calculateSpeedFactors() to applyDefaultSpeedFactors() and made it non static. * Fix issue jMonkeyEngine#1850 (JmeSystem.writeImageFile() throw java.nio.BufferUnderflowException) (jMonkeyEngine#1851) * jme3-jogg: upgrade the j-ogg-all library to v1.0.2 * jMonkeyEngine#1569 Fix license file to be better detected by GitHub (jMonkeyEngine#1855) * jme3-plugins: update the "gson" library to v2.9.1 * workflows/main.yml: update the "checkout" action to v3 * fix: broken link in README.md (jMonkeyEngine#1858) Signed-off-by: Kasper Aaquist Johansen <[email protected]> Signed-off-by: Kasper Aaquist Johansen <[email protected]> * workflows/main.yml: update wrapper-validation-action to v1.0.5 * update wrapper-validation-action to v1.0.5 (one more place) * README.md: SDK v3.5.2 has now been published * Quaternion: javadoc * Add instance culling function in InstancedGeometry (jMonkeyEngine#1865) * Added a workaround to prevent shadow disappearing on instanced geometries away from camera by introducing an instance culling function on InstancedGeometry. There also is a default implementation provided. * Removed the bound-scale hack for shadow disappearing issue from DefaultInstanceCullingFunction. The “right” solution is to have it pay attention to the frustums of whatever shadow-casting lights are around… but anyway developers now can implement their own frustum culling however they like or even "unset" it to disable instance culling which should also resolve the shadow issue. * Remove unused imports. * Fix: make the stencil test functions usable. (jMonkeyEngine#1866) * Fix: make the stencil test functions usable. * Fix: formatting * Fix: formatting * Fix: formatting * Fix: copyright year * upgrade to Gradle v7.6 (for its Java 19 support) * Read shorts properly * More efficient logging * Read unsigned byte properly * Remove unnecessary byte and call the variable c as in the formulas * move SettingsDialog and ErrorDialog to new jme3-awt-dialogs module (jMonkeyEngine#1876) * Refactory Settings/Error dialogs in JmeDialogsFactory and jme3-awt-dialogs * add build.gradle * Add copyright headers * Fix formatting and documentation Co-authored-by: riccardobl <[email protected]> * JmeSurfaceView: Package migration (jMonkeyEngine#1819) * JmeSurfaceView: migration to new package (com.jme3.view.surfaceview) * JmeSurfaceView: migration to new package (com.jme3.view.surfaceview) * upgrade the groovy-test library to v3.0.13 * jme3-core: correct/clarify javadoc * Implementation of a glTF extension loader for KHR_texture_transform (jMonkeyEngine#1869) * Implementation of a glTF extension loader for KHR_texture_transform * Thread-safe version of the glTF extension loader for KHR_texture_transform * Updated thread-safe version of the glTF extension loader for KHR_texture_transform * Fix (switched indices of the translation matrix): thread-safe version of the glTF extension loader for KHR_texture_transform * Added support for texCoord, fixed matrix comparison * Simplified matrix comparison, removed trailing whitespaces * Update to differentiate transformations applied to different UV sets * Improved memory usage for transformMap * Specified Map generic types & removed unnecessary cast Co-authored-by: Manuel <Manuel@DESKTOP-6RJH3UF> * jme3-core: test the com.jme3.math.Triangle class * bugfix: Mesh.getTriangle() may yield an incorrect centroid * Fix jMonkeyEngine#1867 (LightFilter gets applied even if not needed) (jMonkeyEngine#1872) * Add NullLightFilter.java * Add usage of null light filter when rendering shadowmaps * Fix formatting * Make static NullLightFilter final * Fix formatting and author * BlendableAction: Fix JavaDoc for setMaxTransitionWeight & replace assert with IllegalArgumentException (jMonkeyEngine#1881) * Fix jMonkeyEngine#1412 (GltfLoader does not support AO packed in MetallicRoughnessMap) (jMonkeyEngine#1880) * Fix jMonkeyEngine#1882 (J3MLoader always generates mips ignoring MinFilter) (jMonkeyEngine#1884) * Get texture mips generation flag from MinFilter specified in j3m file. * Update copyright date. * Fix J3MLoaderTest failing. * Fix TestMaterialWrite failing. * Update copyright date. * Use Trilinear if no min filter is specified in j3m file. * Add copyright note in J3MOutputCapsule. * Fix J3MLoaderTest failing. * Made extension loaders non-static to avoid concurrency issues (jMonkeyEngine#1886) Now each GltfLoader instantiated via ThreadLocal will have its own instances of extension loaders. * Fix jMonkeyEngine#1883 (Image class wrongly setting GL mips flags inside the constructor) (jMonkeyEngine#1885) * AreaUtils: Migrated package to `com.jme3.util` (jMonkeyEngine#1826) * AreaUtils: Migrated package to `com.jme3.util` * com.jme3.uitl.AreaUtils: removed code duplicates - added `final` class specifier * com.jme3.util.AreaUtils: fixed duplication build error * utils/AreaUtils.java: full migration to the utility package * scene/control/AreaUtils.java: removed utility methods - delegated functionality to `jme3.utils.AreaUtils` * scene/AreaUtils: fixed `jme3.util` package linking typo * Renderer: javadoc correction * update the groovy-test library to v3.0.14 * LICENSE.md: add 2023 to copyright years * Fix jMonkeyEngine#1892 (TestChooser does not show classes list when run with java 8) (jMonkeyEngine#1893) * TestChooser:fix class list not showing when run with java 8. * Update copyright date. * main.yml: use "temurin" openjdk. Fix jMonkeyEngine#1896 (jMonkeyEngine#1897) * README.md: add Demon Lord to the list of published games * Fix jMonkeyEngine#1773 (Wrong particle position when `worldSpace` flag equals to true) (jMonkeyEngine#1889) * Add test case for issue jMonkeyEngine#1773. * Fix wrong particle position when using 'EmitterMeshVertexShape' or 'EmitterMeshFaceShape' and worldSpace flag equal to true. The old code was interpolating particles position toward emitter world position and this was only working fine for EmitterPointShape and in the other shapes this was causing particles not keep the shape because they were being dragged toward emitter position. The new code calculates the distance vector from emitter last location to the current emitter location and subtracts it from particles position to generate a hypothetical position that is used for interpolation. * Add javadoc to TestIssue1773. * Minor javadoc fix. * jme3-niftygui: solve issue jMonkeyEngine#1891 (incorrect fullscreen layout) (jMonkeyEngine#1895) * jme3-lwjgl:updated to lwjgl v2.9.4 hosted by org.jmonkeyengine. Fix jMonkeyEngine#1247, jMonkeyEngine#1215, jMonkeyEngine#947 (jMonkeyEngine#1902) * Fix jMonkeyEngine#1890 (crashes attempting to run example apps in fullscreen with LWJGL v2) (jMonkeyEngine#1898) * jme3-lwjgl:fallback to standard 60Hz fullscreen display mode if the specified frequency in the AppSettings is not available and log a warning. * Fallback to whatever bps or frequency is available. Added a wild-card value to let selecting any bps or frequency available by passing -1. * Support AWT display frequency model. Looks like AWT uses mathematics round to convert float frequency values to int while lwjgl 2 uses mathematics floor. For example if frequency is 59.83, AWT will return 60 but lwjgl 2 will return 59. * Remove redundant check. * Added documentation for getFullscreenDisplayMode method. * When in VR attach the debug scene to the two eye's scenes. Fix#1795 (jMonkeyEngine#1888) * jMonkeyEngine#1795 When in VR attach the debug scene to the two eye's scenes This ensures they show up correctly * jMonkeyEngine#1795 Whitespace corrections * jMonkeyEngine#1795 Further whitespace corrections * jMonkeyEngine#1795 Yet more whitespace corrections * jMonkeyEngine#1795 Add explanatory comment as to why VR and non-VR have totally different approaches * Refactored PBR Terrain to use new for-loops. Fix jMonkeyEngine#1785 (jMonkeyEngine#1901) Drastically reduced code by utilizing JME's new potential for define-compatible for-loops in shaders. Also cleaned up some other little things like indentations, comments, and code placement so that the code is much more organized and easier to understand. * add the Spatial.addControlAt() method (jMonkeyEngine#1899) * JmeContext: add a getSystemListener() method (jMonkeyEngine#1894) * jme3-examples: add tests for issue jMonkeyEngine#1903 * Refactored Advanced PBR Terrain to use new for-loops (jMonkeyEngine#1904) * Refactored Advanced PBR Terrain to use new for-loops Similar to my recent pull request doing the same for the base PbrTerrain shader (jMonkeyEngine#1901) this PR also adds for-loop support to the advanced version of the pbr shader that uses texture arrays * Update PBRTerrain.frag * Update AdvancedPBRTerrain.frag * Update AfflictionLib.glsllib (jMonkeyEngine#1905) This PR goes along with my last PR cleaning up the AdvancedPBRTerrain.j3md shader. The method getTriPlanarBlendFromTexArray() was put into this glsllib that contains all of the other commonly used functions for the pbr terrain shaders. * common.gradle: set class files compatible with Java 8 using "release" option (jMonkeyEngine#1907) * common.gradle: set class files compatible with Java 8. This will keep java 8 compatibility when it is compiled with newer java versions. * Merge with existing block. * Reformat code. * common.gradle: add "Created-By" jar manifest to show Java version and vendor name (jMonkeyEngine#1913) * common.gradle: add Created-By in jar manifest to show java version used to create the jar. * Also add vendor name. * ParticleEmitter: improve code readability. Apply the DRY principle (jMonkeyEngine#1912) * add 4 getters to JmeContext for screen position and frame-buffer size (jMonkeyEngine#1911) * test and fix for jMonkeyEngine#1909 (NPE while generating tangents) (jMonkeyEngine#1910) * add a JUnit test for issue 1909 (NPE while generating tangents) * solve issue jMonkeyEngine#1909 (NPE while generating tangents) * jme3-lwjgl: bump to lwjgl 2.9.5 (jMonkeyEngine#1914) * Fix jMonkeyEngine#1917 (RendererException in ScreenshotAppState: Attempting to upload empty buffer) (jMonkeyEngine#1918) * PBRLighting: fix comment describing packed MetallicRoughnessMap (jMonkeyEngine#1921) Updated a comment about the MetallicRoughness map that previously said the Red channel is unused - changed to instead say that the red channel of MR map stores the AO value if AoPackedInMRMap is true. * solve issue jMonkeyEngine#1919 (underflow while generating tangents) (jMonkeyEngine#1920) * jme-core: add a test for issue jMonkeyEngine#1919 (underflow generating tangents) * MikktspaceTangentGenerator: solve jMonkeyEngine#1919 (underflow generating tangents) * main.yml: deploy with jdk17 (jMonkeyEngine#1922) * Fix jMonkeyEngine#1923 (OSSRH artifacts are build with different java version) (jMonkeyEngine#1924) * main.yml: build on pushes to the new v3.6 branch * gradle.properties: next release from "master" branch should be v3.7.0 * resolve issue jMonkeyEngine#1926 (unnecessary dependencies) (jMonkeyEngine#1927) * buildscript: move def of "niftyVersion" to "common.gradle" (shared between projects) * jme3-testdata: rm dependency on "nifty-style-black" (redundant with "jme3-niftygui") * buildscript: mv "nifty-examples" dependency from "jme3-testdata" to "jme3-examples" * solve issue jMonkeyEngine#1928 (OutOfMemoryError in FBX importer) (jMonkeyEngine#1929) * solve issue jMonkeyEngine#1928 (OutOfMemoryError in FBX importer) * tweak the new javadoc * solve issue jMonkeyEngine#1930 (NPE in FbxLayerElement) (jMonkeyEngine#1931) * solve issue jMonkeyEngine#1932 (class cast exceptions in FBX importer) (jMonkeyEngine#1934) * solve issue jMonkeyEngine#1933 (unsupported operation in FbxNode) (jMonkeyEngine#1936) * solve issue jMonkeyEngine#1937 (NPE in FbxObject) (jMonkeyEngine#1938) * solve issue jMonkeyEngine#1939 [NPE in FbxMesh.applyCluster()] (jMonkeyEngine#1940) * FBXCluster: create empty arrays if the cluster contains no keyframes * FbxLoader: don't construct an animation if there are no keyframes * update Groovy to v3.0.15 * Update Application.start javadoc. (jMonkeyEngine#1947) * Update RenderState.setLineWidth javadoc. (jMonkeyEngine#1948) * Fix jMonkeyEngine#1945 (IllegalStateException when running TestAWTPanels with LWJGL 3) (jMonkeyEngine#1949) * solve issue jMonkeyEngine#1879 (compile-time error in Skinning.glsllib) (jMonkeyEngine#1942) * Fix issue jMonkeyEngine#1558 (TestAWTPanels crashes with LWJGL v3 on Linux) (jMonkeyEngine#1944) * TestAwtPanels: apply swing system LAF. This is needed to prevent JVM crash on Linux and LWJGL 3. (See issue jMonkeyEngine#1558) * Use single class imports. * solve issue jMonkeyEngine#1806 (global FrameInterpolator violates threading model) (jMonkeyEngine#1943) * solve issue jMonkeyEngine#1806 (global FrameInterpolator violates threading model) * FrameInterpolator: deprecate the global instance * Fix a typo in LwjglWindow (jMonkeyEngine#1953) * Add WaterFilter.getReflectionView method (jMonkeyEngine#1951) * Added WaterFilter.getReflectionView method. * Update javadoc. * README.md: delete a dead link (Maker's Tale) * README.md: add a link to Wild Magic * resolve issue jMonkeyEngine#1955 (Can not play vorbis audio on Android API 31+) (jMonkeyEngine#1956) * android-native-vorbis: fix double asset file descriptor closure * NativeVorbis: better names and javadocs * NativeVorbisFile#readIntoBuffer: specifies the start and the end of the read * NativeVorbisFile: better explanation for the output buffer on read functions * com_jme3_audio_plugins_NativeVorbisFile.c: refactored logs * NativeVorbisFile: some docs enhances * NativeVorbisLoader: added updated jme3-copyright * [skip ci] update natives snapshot * jme3-jogg: remove dependency on Java Media Framework (jMonkeyEngine#1962) * solve issue jMonkeyEngine#1960 (use jme3-jogg for loading ogg files on android) (jMonkeyEngine#1961) * solve issue jMonkeyEngine#1963 (TestMusicPlayer fails to load AL library on lwjgl2) (jMonkeyEngine#1964) * TestMusicPlayer: fix UnsatisfiedLinkError when using lwjgl2. Solves issue jMonkeyEngine#1963 * Add missing load function for "openal" natives. * Removed the unnecessary check for lwjgl 2 in classpath. * Fix comment * Replace Exception with warning in TerrainPatch (jMonkeyEngine#1966) * Replace Excpetion with warning in TerrainPatch PR following up on the discussion in this thread: https://hub.jmonkeyengine.org/t/terrain-collision-exception/46491/6 * Update TerrainPatch.java * Update TerrainPatch.java * Update TerrainPatch.java * Update TerrainPatch.java * Update TerrainPatch.java * Update TerrainPatch.java * Update TerrainPatch.java * Cleanup NativeLibraryLoader & fix wrong library path (jMonkeyEngine#1967) * Cleanup NativeLibraryLoader * Fix wrong library path * solve issue jMonkeyEngine#1969: missing check in GLRenderer.clearVertexAttribs() (jMonkeyEngine#1970) * solve issue jMonkeyEngine#1975: TestAttachDriver doesn't reset properly (jMonkeyEngine#1976) * Improve NativeLibraryLoader (jMonkeyEngine#1973) * Improve NativeLibraryLoader. * Add javadoc. * Moved library extraction requirement check into a separate method. * Fix javadoc. * Refactor library extraction check method. * Extract natives to system temp directory retrieved by System.getProperty("java.io.tmpdir") instead of working directory. * Renamed enum "Openal" to "OpenAL" and added javadoc on NativeLibraries. * Update comments. * Deploy master branch commits as snapshot (jMonkeyEngine#1983) * Deploy main branch commits as snapshot * Snapshot builds don't have a Release artifact * restrict snapshot to actual commits on master branch * Deploy steps don't actually use test-run maven artifacts * Partial Revert. We need that artifact * Fix sonatype snapshots repo url as mentioned in https://central.sonatype.org/publish/publish-guide/ * Allow use of Emissive color as a multiplier with EmissiveMap in PBRLighting (jMonkeyEngine#1979) * Add support for NormalScale in PBRLighting & GltfLoader (jMonkeyEngine#1980) * Added NormalScale factor in PBRLighting. The scalar parameter applied to each normal vector of the normal map. This value scales the normal vector in X and Y directions using the formula: `scaledNormal = normalize((<sampled normal texture value> * 2.0 - 1.0) * vec3(<normal scale>, <normal scale>, 1.0))`. * Add support for reading NormalScale in GltfLoader. * Add support for AoStrength in PBRLighting & GltfLoader (jMonkeyEngine#1981) * Added AoStrength factor in PBRLighting. A scalar multiplier controlling the amount of occlusion applied. * Add support for reading AoStrength in GltfLoader. * Fix ao calculation to follow gltf specs. * Update comment on AoStrength mentioning the min and max values. * Clamp ao to 0 for negative values that might cause by applying AoStrength > 1. * Use glsl clamp instead of max. * update Groovy to v3.0.16 * Some javadoc cleanup (jMonkeyEngine#1986) * Fix some invalid HTML tags * Correct deprecation annotations * Doc-comments cleanup - Corrected some typos, grammar, etc. - reflowed egregiously long comment lines to comply with column limits * README.md: latest stable version of Engine * LwjglContext: re-initialize renderer on context restart (lwjgl 2) (jMonkeyEngine#1988) * LwjglContext: initialize renderer on context restart (lwjgl 2). * Reset GL objects in renderer when context restart. * README.md: add Mravelous Marbles to the list of JME-powered games * update the LWJGL3 libraries from v3.3.1 to v3.3.2 * update Groovy to v3.0.17 * correctly handle negative IDs in getUniqueId() methods (jMonkeyEngine#1991) * NativeLibraryLoader: more detailed exception in computeNativesHash() (jMonkeyEngine#2001) * README.md: add "Boxer" to the project list * solve issue jMonkeyEngine#2003 (ParticleDepositionHeightMap.load return value) (jMonkeyEngine#2005) * solve issue jMonkeyEngine#2002 (TerrainGridTileLoaderTest fails to load tiles) (jMonkeyEngine#2006) * solve issue jMonkeyEngine#2002 (TerrainGridTileLoaderTest fails to load tiles) * TerrainGridTileLoaderTest: add a clarifying comment * solve issue jMonkeyEngine#2011 (app crashes when using OpenGL version 3.0 and 3.1 with LWJGL 3) (jMonkeyEngine#2009) * fix system crush issue when set desktop AppSetting.setRenderer below 3.2 * Revert "fix system crush issue when set desktop AppSetting.setRenderer below 3.2" This reverts commit 11b7c9e. * fix system crush issue when set desktop AppSetting.setRenderer below 3.2. This fix is reedited by instruction of ali_rs --------- Co-authored-by: ray <[email protected]> * solve issue jMonkeyEngine#2007 (instanced objects are culled when using WaterFilter) (jMonkeyEngine#2008) * Fix issue with InstancedGeometry that uses the wrong camera for "instance culling" check. * Minor javadoc update. * Variables should start with lower-case. (jMonkeyEngine#2013) New PullRequest as suggested in jMonkeyEngine#2012 Co-authored-by: Starcommander <[email protected]> * solve issue jMonkeyEngine#1992: better messages in spatial assertions (jMonkeyEngine#1993) * jMonkeyEngine#1992 Improve the messages being reported from spatial assertions * jMonkeyEngine#1992 Make clear what name is in the assertion messages * jMonkeyEngine#1992 Whitespace correction * solve issue jMonkeyEngine#2015 (Picture class lacks 2 getters) * CloneableSmartAsset: clarify the setKey() javadoc (jMonkeyEngine#2018) * update Gradle to v7.6.1 --------- Signed-off-by: Kasper Aaquist Johansen <[email protected]> Co-authored-by: Scrappers Team <[email protected]> Co-authored-by: Github Actions <[email protected]> Co-authored-by: Riccardo Balbo <[email protected]> Co-authored-by: Scrappers <[email protected]> Co-authored-by: Stephen Gold <[email protected]> Co-authored-by: Florian Frankenberger <[email protected]> Co-authored-by: Wyatt Gillette <[email protected]> Co-authored-by: Lukas-Habring <[email protected]> Co-authored-by: Lukas Habring <lukas@Lukas-PC> Co-authored-by: JosiahGoeman <[email protected]> Co-authored-by: Paul Speed <[email protected]> Co-authored-by: Ali-RS <[email protected]> Co-authored-by: Toni Helenius <[email protected]> Co-authored-by: Jan Schäfer <[email protected]> Co-authored-by: Kasper Aaquist Johansen <[email protected]> Co-authored-by: Michael Zuegg <[email protected]> Co-authored-by: manuelrmo <[email protected]> Co-authored-by: Manuel <Manuel@DESKTOP-6RJH3UF> Co-authored-by: Noeri Huisman <[email protected]> Co-authored-by: richardTingle <[email protected]> Co-authored-by: Ryan McDonough <[email protected]> Co-authored-by: Sailsman63 <[email protected]> Co-authored-by: Raymond Young <[email protected]> Co-authored-by: ray <[email protected]> Co-authored-by: Paul Kashofer <[email protected]> Co-authored-by: Starcommander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the matching java types to VarTypes and uses them to perform runtime type checks on MatParam.setValue().
Should be merged after #1759