Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R.3: raw pointer #2133

Open
jonnygrant opened this issue Sep 5, 2023 · 3 comments
Open

R.3: raw pointer #2133

jonnygrant opened this issue Sep 5, 2023 · 3 comments

Comments

@jonnygrant
Copy link

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#r3-a-raw-pointer-a-t-is-non-owning

The English sounds a little quirky:

"A major class of exception is legacy code"

I suggest to change that to:

"A major exception to this rule is legacy code"

@iglesias
Copy link
Contributor

iglesias commented May 4, 2024

Hi, as a non-native speaker, may I ask, what does quirky mean?

I see the point that "class" in the first sentence is superfluous. Although, following along that reasoning, "to this rule" added to exception is redundant too.

@jonnygrant
Copy link
Author

Hi,

That's a good idea. So I propose to change to

"A major exception is legacy code"

Quirky means peculiar.

@iglesias
Copy link
Contributor

iglesias commented May 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants