Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build when using system jsoncpp #7080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix build when using system jsoncpp #7080

wants to merge 1 commit into from
+2 −1

Conversation

hott-onin-1
Copy link

@hott-onin-1 hott-onin-1 commented Nov 28, 2024 •
edited
Loading

Fix building the library when using system jsoncpp

Type

  • Bug fix (non-breaking change which fixes an issue): No issue created

Motivation and Context

I was having a link error when using an external jsoncpp installation. It was fixed by changing the target name from jsoncpp_lib to jsoncpp::jsoncpp_lib in the third party cmake file. I suspect this is a typo?

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

The target name for external jsoncpp lib seems wrong in the third party cmake file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hott-onin-1