Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated delocate-fuse to delocate-merge. #6940

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

timohl
Copy link
Contributor

@timohl timohl commented Aug 31, 2024

Updated delocate-fuse to delocate-merge (got removed in delocate>=0.12.0).

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

The following error occurs in the Fuse universal2 wheel (3.11, false) CI workflow:

'delocate-fuse' is no longer available.
To fuse two wheels together use 'delocate-merge'.
NOTE: 'delocate-merge' does not overwrite the first wheel.
It creates a new wheel with an automatically determined name.
If the old behavior is needed (not recommended), pin the version to 'delocate==0.11.0'.

delocate 0.12.0 released on the 29th of August, so only the latest CI runs show this error.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

The following warning from delocate describes what changed with delocate>=0.12.0:

:warning: Note: In previous versions (<0.12.0) making dual architecture binaries was performed with the delocate-fuse command.
This commannd would overwrite the first wheel passed in by default.
This led to the user needing to rename the wheel to correctly describe what platforms it supported.
For this and other reasons, wheels created with this were often incorrect.
From version 0.12.0 and on, the delocate-fuse command has been removed and replaced with delocate-merge.
The delocate-merge command will create a new wheel with an automatically generated name based on the wheels that were merged together.
There is no need to perform any further changes to the merged wheel’s name.
If the old behavior is needed (not recommended), pin the version to delocate==0.11.0.

I just changed from delocate-fuse to delocate-merge.

Copy link

update-docs bot commented Aug 31, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@timohl timohl marked this pull request as ready for review August 31, 2024 17:30
@benjaminum benjaminum added this to the v0.19 milestone Sep 3, 2024
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @timohl !

@ssheorey ssheorey merged commit b2d1f78 into isl-org:main Sep 4, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants