Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation #6307

Merged
merged 23 commits into from
Aug 17, 2023
Merged

Improve documentation #6307

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2e8ee6d
Add install with upgrade option when installing latest development pa…
saurabheights Aug 10, 2023
86e7a2f
util/install-deps-python.sh was removed in https://github.com/isl-org…
saurabheights Aug 10, 2023
3ea347d
Grammar fix.
saurabheights Aug 11, 2023
381882d
Move open3d_ml and arm to after docker.
saurabheights Aug 11, 2023
17a27a3
organize TOC - Move C++ and Contribution to end and keep python secti…
saurabheights Aug 11, 2023
0b8edfd
Fix sphinx warnings (Title underline too short).
saurabheights Aug 11, 2023
201b6bd
Fix extra heading drop when going one level down.
saurabheights Aug 11, 2023
5d798fd
Fix cross reference links
saurabheights Aug 11, 2023
42a1106
Add files/directories to ignore for sphinx, reduces inconsistency war…
saurabheights Aug 12, 2023
4c48feb
Fix `Unknown directive type "code_block"` warning.
saurabheights Aug 12, 2023
9af3bdc
Add uvmaps to official docs, fix - `WARNING: document isn't included …
saurabheights Aug 12, 2023
d71cd20
Fix yaml lexer name - See https://pygments.org/languages/
saurabheights Aug 12, 2023
9c956d2
Correct the extension
saurabheights Aug 12, 2023
fb7c71c
Fix warnings - `Inline substitution_reference start-string without en…
saurabheights Aug 12, 2023
c99fd1b
Minor code refactoring of make_docs.py
saurabheights Aug 13, 2023
af3ba12
Only copy open3d_tutorial.py once
saurabheights Aug 13, 2023
04d8799
Move list of classes to a global variable
saurabheights Aug 14, 2023
3d82438
Use f-strings as requested in PR
saurabheights Aug 14, 2023
549c739
Add python_api_in as ignored directory.
saurabheights Aug 15, 2023
0d675cd
Revert all changes made for correcting vertical bar in pydocs
saurabheights Aug 15, 2023
a3cbf05
Fix pybind docs with literal block for tree output
saurabheights Aug 15, 2023
e807806
Fix doxygen docs with code block for tree output
saurabheights Aug 15, 2023
cfd570f
Correct class names in doxygen docs for RedWood dataset
saurabheights Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/jupyter/t_pipelines/t_icp_registration.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"#### 1. Set Inputs and Parameters"
"### 1. Set Inputs and Parameters"
Copy link
Contributor Author

@saurabheights saurabheights Aug 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More info on why here - spatialaudio/nbsphinx#373 (comment)

P.S. Just noticed that the changes here are getting over written somehow when building docs. Will check and fix this commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found my oversight. So, changes here are getting ignored because a pre-built t_icp_registration notebook file is getting downloaded in make_docs.py due to #4321.

Is the documentation still built without cuda on CI/CD?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It is safe to keep the changes here now, we can study the best option regarding large notebook files in another PR.

]
},
{
Expand Down Expand Up @@ -453,7 +453,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"#### 2. Get Registration Result from ICP"
"### 2. Get Registration Result from ICP"
]
},
{
Expand Down Expand Up @@ -602,7 +602,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"#### 1. Set Inputs and Parameters"
"### 1. Set Inputs and Parameters"
]
},
{
Expand Down Expand Up @@ -656,7 +656,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"#### 2. Get Registration Result from Multi-Scale ICP"
"### 2. Get Registration Result from Multi-Scale ICP"
]
},
{
Expand Down Expand Up @@ -884,7 +884,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"#### 1. Set Inputs and Parameters"
"### 1. Set Inputs and Parameters"
]
},
{
Expand Down