Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use limited_joint_handle #14

Open
fmessmer opened this issue Mar 21, 2016 · 6 comments
Open

Use limited_joint_handle #14

fmessmer opened this issue Mar 21, 2016 · 6 comments

Comments

@fmessmer
Copy link
Member

fmessmer commented Mar 21, 2016

Create a new branch that uses the limited_joint_handle package from https://github.com/ros-industrial/ros_canopen/tree/limited_joint_handle

@fmessmer FYI

@fmessmer fmessmer changed the title Use limited_joint_handled Use limited_joint_handle Apr 2, 2016
@fmessmer
Copy link
Member Author

@ipa-mdl just came across this
Can't remember what the status of the limited_joint_handle ros_canopen branch has been...is this still intended to be merged?

@fmessmer
Copy link
Member Author

How was this related to https://github.com/ipa320/cob_control/issues/72

@mathias-luedtke
Copy link

Not sure what to do here.
I guess I will add an option to turn off all ROS-based joint limits in ros_canopen.
joint_limits_controller can be added as an option, perhaps in ros_controllers or cob_control.

@fmessmer
Copy link
Member Author

fmessmer commented Jan 21, 2017

Summarizing some discussion with @ipa-mdl:
Initial idea for limited_joint_handle was because of ros-industrial/ros_canopen#141 and linked discussions.
However, the limited_joint_handle as an alternative to ros_control/joint_limits_interface was not as successful as expected on the hardware.
Thus, we currently do limit handling directly in hardware and an enforce_limit flag has been implemented in ros-industrial/ros_canopen#215 to switch off ros_control/joint_limits_interface.
Still, "joint_limit_controller" (e.g. for limiting "jumps") might be helpful that could be chained with other controllers (e.g. JointGroupPositionController) before their command is processed by the hardware_interface

@fmessmer
Copy link
Member Author

fmessmer commented Jan 21, 2017

Conclusion for cob_gazebo_ros_control
It's not desired to integrate limited_joint_handle within the gazebo plugin.
However, it might be helpful to enable/disable the ros_control/joint_limits_interface as done in ros_canopen and then - once available - use the "joint_limit_controller"...

@fmessmer
Copy link
Member Author

fmessmer commented Jan 21, 2017

@ipa-mdl
Let's continue the discussion about the "joint_limit_controller" in https://github.com/ipa320/cob_control/issues/72 as it is not directly related to cob_gazebo_ros_control plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants