You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
coming here from #35 (comment), @gsong was so kind to offer he would think about an option on how to toggle the behavior of one of the core methods within this library.
We are talking about the _make_request method here, which invokes response.raise_for_status() in order to raise exceptions on all HTTP requests to the OPS API which respond with HTTP status >= 400.
For reasons I am currently not able to remember exactly, we wanted to turn that behavior off within PatZilla.
Most probably it was because the exception bubbling up from this method lacked important information from the original request object we wanted to present to the user, like details from OAuth failures or rate limiting errors we are extracting from HTTP response headers or similar things.
Please advise if we are getting this wrong and the same things could be achieved with this call in place. Thanks!
With kind regards,
Andreas.
The text was updated successfully, but these errors were encountered:
Hi there,
coming here from #35 (comment), @gsong was so kind to offer he would think about an option on how to toggle the behavior of one of the core methods within this library.
We are talking about the
_make_request
method here, which invokesresponse.raise_for_status()
in order to raise exceptions on all HTTP requests to the OPS API which respond with HTTP status >= 400.For reasons I am currently not able to remember exactly, we wanted to turn that behavior off within PatZilla.
Most probably it was because the exception bubbling up from this method lacked important information from the original request object we wanted to present to the user, like details from OAuth failures or rate limiting errors we are extracting from HTTP response headers or similar things.
Please advise if we are getting this wrong and the same things could be achieved with this call in place. Thanks!
With kind regards,
Andreas.
The text was updated successfully, but these errors were encountered: