Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Only gossip solid transactions #1512

Open
GalRogozinski opened this issue Jul 11, 2019 · 2 comments · May be fixed by #1646
Open

Only gossip solid transactions #1512

GalRogozinski opened this issue Jul 11, 2019 · 2 comments · May be fixed by #1646

Comments

@GalRogozinski
Copy link
Contributor

Description

We only want to pass solid transactions to other nodes.

Motivation

Non solid transactions can't affect the ledger state. They might be plane spam.
No need to gossip them.

Requirements

  1. If a transaction gets quickly solid upon receival, add it to the networking broadcast queue
  2. Once a transaction becomes solid via the TransactionValidator solidifier, add it to the broadcast queue.
  3. Once a transaction becomes solid via the MilestoneSolidifier add it to the broadcast queue
  4. Once a transaction becomes solid via TipsSolidifier (off by default) add it to the broadcast queue.
@GalRogozinski
Copy link
Contributor Author

TipsSolidifier is gone,
One less requirement :-P

@jakubcech jakubcech added L-Groom This issue needs to be groomed and removed L-Groom This issue needs to be groomed labels Aug 15, 2019
@jakubcech
Copy link
Contributor

jakubcech commented Aug 15, 2019

We shouldn't expose the network layer directly, but add an abstraction in-between.
Avoid duplicates in the queue.

This will affect how nodes sync: e.g.,: nodes in chain A -> B - > C, if the syncing process starts top to bottom (If B hears a transaction), B will wait until it is solid and C will not start syncing until B is solid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants