Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Ionic v1 is not compatible with angular 1.7.0 #386

Open
stripathix opened this issue May 18, 2018 · 8 comments
Open

Ionic v1 is not compatible with angular 1.7.0 #386

stripathix opened this issue May 18, 2018 · 8 comments

Comments

@stripathix
Copy link

stripathix commented May 18, 2018

When will ionic v1 be upgraded to support angular 1.7.x ?

There are few breaking changes if upgrade angular to 1.7.0.

https://github.com/angular/angular.js/blob/master/CHANGELOG.md

One issue that I am getting is due to this breaking change on $ionicLoading

$timeout: throw when trying to cancel non-$timeout promise

@nayfin
Copy link

nayfin commented Apr 24, 2019

We are getting the same error when trying to use Angular 1.7 with Ionic 1.
Docs describe problem here, but it looks like we will have to submit a PR to Ionic to change $ionic.loading.show, hide, cancel etc...
I wish they would have maintained it up to Angular 1.7....

Another library is affected by this as well

@stripathix
Copy link
Author

@nayfin I migrated to Ionic4 + Vue. I can say it was a good decision.

@nayfin
Copy link

nayfin commented Apr 24, 2019

This is for an enterprise app, so that's not really an option. Thanks though.

@davidecampello
Copy link

Hi @nayfin, have you found a solution for this problem? Thanks

@nayfin
Copy link

nayfin commented May 23, 2019

@Camdav We got pulled into something else, but we started a POC where we upgraded to AngularJS 1.7 pulled out all $ionicLoading calls, then replaced it with a web component of the angular material loading component that we built with angular elements. We needed to use web components anyway, it was the main reason we had to upgrade angular to 1.7, so this path wasn't terrible for us. If you don't feel like using web components, you could just replace the $ionicLoading with a loading component from the old angular material library or something similar.

@davidecampello
Copy link

Thank you for the answer!

@marcochavezf
Copy link

marcochavezf commented Sep 17, 2019

I fixed this changing
var loadingShowDelay = $q.when(); to var loadingShowDelay = $timeout(noop);
in https://github.com/ionic-team/ionic-v1/blob/master/release/js/ionic-angular.js#L2267

@FitFingers
Copy link

I fixed this changing var loadingShowDelay = $q.when(); to var loadingShowDelay = $timeout(noop); in https://github.com/ionic-team/ionic-v1/blob/master/release/js/ionic-angular.js#L2267

This solved the issue for me. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants