Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better check_depth/check_onland output #47

Open
samuelbosch opened this issue Nov 29, 2017 · 1 comment
Open

Better check_depth/check_onland output #47

samuelbosch opened this issue Nov 29, 2017 · 1 comment

Comments

@samuelbosch
Copy link
Contributor

Related to the output from check_depth/check_onland I would propose two changes:

  1. remove the report=true parameter and always return both the dataframe and the report in a list with two elements: "problems" and "report"
  2. in the report add 4 additional columns: lon, lat, value, comparison_value (= name to be discussed)

These changes would allow two things:

  1. prevent running the xylookup twice with the same data
  2. new inspection functions and plotting functions e.g. plot the difference between bathymetry and the depth values on a map
@samuelbosch
Copy link
Contributor Author

Additionally I would also add an errorcode column for easy filtering of records with specific errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant