Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Jumanji RWARE reward shape mismatch #1110

Open
lbeyers opened this issue Oct 24, 2024 · 1 comment
Open

[BUG]Jumanji RWARE reward shape mismatch #1110

lbeyers opened this issue Oct 24, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lbeyers
Copy link
Contributor

lbeyers commented Oct 24, 2024

We found that in the 4ag RWARE task, env.reward_spec().generate_value() gives something of shape (), but the reward that environment outputs is actually of shape (num_agents).

This is curious because I believe the scenario should output a reward of shape ().

Maybe it's a wrapper thing?

@lbeyers lbeyers added the bug Something isn't working label Oct 24, 2024
@sash-a
Copy link
Contributor

sash-a commented Nov 5, 2024

Thanks Louise looks like this is a bug, we duplicated the reward and discount but never update the specs, my vote is to just not duplicate it and add a dummy agent dim so everything behaves the same.

@sash-a sash-a added the good first issue Good for newcomers label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants