Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CHANGELOG entry for 0.5.1 #328

Open
wjessop opened this issue Jul 30, 2021 · 5 comments
Open

No CHANGELOG entry for 0.5.1 #328

wjessop opened this issue Jul 30, 2021 · 5 comments

Comments

@wjessop
Copy link

wjessop commented Jul 30, 2021

It looks like this is a relatively small change, but as this gem doesn't explicitly support semantic versioning it's hard to know if there are any breaking changes with the patch release without release notes.

@jeremy
Copy link
Contributor

jeremy commented Aug 23, 2021

There are breaking changes.

@wjessop
Copy link
Author

wjessop commented Aug 24, 2021

Would you be able to expand on what those are? Much appreciated if you are!

@jeremy
Copy link
Contributor

jeremy commented Aug 25, 2021

Here's what I've seen:

@mlarraz
Copy link
Member

mlarraz commented Aug 25, 2021

Apologies, I did not update the Changelog on master since technically this release is on a separate branch, but you can see the changes in the release: https://github.com/instacart/makara/releases/tag/v0.5.1

This contains all the same changes as master except for the deprecations of master and slave, which were reported to have caused issues but we have not had a chance to investigate.

@wjessop
Copy link
Author

wjessop commented Aug 26, 2021

Thanks @jeremy / @mlarraz, that's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants