Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reproducibility of vignettes #333

Open
gowerc opened this issue Mar 17, 2022 · 0 comments
Open

Ensure reproducibility of vignettes #333

gowerc opened this issue Mar 17, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gowerc
Copy link
Collaborator

gowerc commented Mar 17, 2022

It looks like the advanced vignette slightly changes on every rerun (see diff below) would be good to fix it so that it only changes if the actual code is updated...

<span id="cb9-20"><a href="#cb9-20" aria-hidden="true" tabindex="-1"></a><span class="co">#&gt; &lt;bytecode: 0x7fa8bb8604a8&gt;</span></span>
<span id="cb9-20"><a href="#cb9-20" aria-hidden="true" tabindex="-1"></a><span class="co">#&gt; &lt;bytecode: 0x7f9546ca2148&gt;</span></span>

EDIT:

May also be worth augmenting the cicd job to build the vignettes to also re-commit the files back to the repo (i.e. so they are auto built via cicd)

@gowerc gowerc added the bug Something isn't working label Mar 17, 2022
@gowerc gowerc assigned gowerc and unassigned gowerc Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants