-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values for impute's references #286
Comments
@gowerc How is it possible to understand which level of vars$group refers to control and which to intervention, without any specification from the user? I agree most of cases will be "Control" = "Control", "Intervention" = "Control" but I think it is easy and clear for the user. |
I was thinking of just using standard factor notation where the first level is considered to be the reference/control. i.e.
I just figured that this likely covers 90% of real world usecase so would make sense to default to it to save users some hassle. No worries if you feel its more likely to add complications / confusion |
Easy enough but I still feel it's better to force the user to provide the reference manually whenever reference-based imputation is used. |
I was wondering whether we should provide default values for references in impute ? As in I imagine in 90% of cases people are just going to do
c("placebo" = "placebo", "treatment" = "placebo")
so I'm wondering if we should just automatically infer this based upon the labels of thegroup
variable if nothing is passed to the arguement (just makes it slightly easier for users I am thinking)i.e. (pseudo code)
The text was updated successfully, but these errors were encountered: