Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert examples to using real objects so they can actually be run. #187

Open
gowerc opened this issue Sep 23, 2021 · 1 comment
Open

Convert examples to using real objects so they can actually be run. #187

gowerc opened this issue Sep 23, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@gowerc
Copy link
Collaborator

gowerc commented Sep 23, 2021

Comment from @danielinteractive

try to avoid use of “dontrun” as in e.g. here - e.g. for shorter run time consider less iterations, or starting from intermediate objects to focus only on the function documented here
reason: you want to be confident that the examples really run without errors

Yeah you could export those. So my idea was:
draws -> example_draws
impute -> example_impute
analyse -> example_analyse
pool -> example_pool
and use these example_* objects in the examples.

@gowerc gowerc added the enhancement New feature or request label Sep 23, 2021
@gowerc gowerc added this to the CRAN Release milestone Sep 23, 2021
@nociale nociale added the To be done Must be done label Nov 9, 2021
@gowerc gowerc removed the To be done Must be done label Jan 24, 2022
@gowerc gowerc removed this from the CRAN Release milestone Feb 17, 2022
@nociale
Copy link
Collaborator

nociale commented Sep 16, 2022

@pengguanya If we go with the idea of exporting draws, impute, analyse, and pool objects, I think we can re-use the example of the quickstart vignette. It uses Bayesian multiple imputation. I suggest we start implementing the examples from the functions using the code reported in the quickstart vignette, and then if we see that for any example we need a draws object related to a conditional mean imputation approach, I am happy to provide you the code for that.

Kind regards,
Alessandro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants