-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure for author, event and year #9
Comments
I think events being the "authors" songs is more of an exception so it would be a bit much to include a separate metadata field for that, just using the author field. I do however think that it's very resonable to have year created as separate field. This would allow any application to format years freely. When it comes to program year and nickname I think that should be up to the author/contributor, so if someone is more identified by their nickname they can use only nickname as author and if someone wants to be identified with their program year it can be up to them. So that I think is better to leave on a "per PR" basis. |
Thoughts @epicmeme? |
Fair point with the nicknames and program-year. I didn't mean to force people to add them, but if you use them, it would be nice if all of them were formatted the same way. So an addition to the README is probably the only thing needed to keep it somewhat consistent. Also sure that events are a bit more of an exception, but IMHO it's nice to see where a song is from if that is known. We also have quite a few songs where the actual event is actually written, but currently in the |
I think an addition to the README would be good. Personally I'd like to have more of an understanding of how much this occurs before I'd like to add another field. Currently all fields are things that are applicable to nearly every song (even if the data is currently missing). The only songs where we can't realistically add data for fields is when the melody is a folk song, but many songs are written entirely without an event in mind. We'd also need to have a field for the event year then to keep consistency. It's possible that it's a good addition, but atm it seems like it would be used very sporadically. |
Yeah, I agree that it's probably not enough for the work to implement it when it's not going to be used that much. I'll look into our current songs how many have events and such. But as you said earlier, Anyhow, I'll just start writing a part in the README for how to format the author with some examples soon :) |
I think we could make all the tags optional, and then create the auto-formatter with different output depending on the fields available. |
That is a really good way to do it! Then we don't have to check for formatting at every PR in the future. I'll look into if I can manage to code that in and see how it works out in the end. |
Currently, we don't have a unified system for how the structure of the author of a song is, where it was first sung and which year.
For example,
Moder Kista
has the author tagDavid Larsson, IT00
whereDavid Larsson
is the name of the author andIT00
is which year and the program he studied.While on the other hand,
Vikingen
has the author tagSångarstriden, Lund, 1981
whereSångarstriden
is the event,Lund
is the city of the event and1981
is the year of the event/the year the song was made.As you can clearly see, we have no real structure for the author tag. Therefore, I suggest two possible solutions:
event
andyear
(just suggestions, doesn't have to be exactly these tag names) where the event and optional city are added in theevent
tag and the year of the song creation is added in theyear
tag. Theyear
tag could also be confusing, some people may think that it's the year the song was added to the songbook, so this idea might need more refinement.If we go with the tags, then the code can automatically format the author's name, program, event and year into a predefined format. Where I suggest we use the following:
FirstName "NickName" LastName, ProgramYear (Event, City, Year)
For example from
Jag ska festa
:Stefan "Stege" Gennert, D86, och Anders "Pellefjant" Bjerkén, D87 (Sångarstriden, Lund, 1987)
The text was updated successfully, but these errors were encountered: