-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few Artist's all song download gives an error after some number of songs #16
Comments
It seems the error happened while adding meta data. Will try fixing the add_tags or will probably skip adding meta data to those songs so that the download can continue. |
@adimrsingh Now it should continue to download all songs but those not available in 320kbps will not have any meta data. Hope this is a satisfying enough fix. I'll look into it sometime later. But I can't make any guarantees. |
Yup, that did fixed the download issue. And It's a fair enough fix. I just added a commit to the download_manager.py , no functionality added just numbered the filename also I sent you a pull request regarding it. |
@monuyadav016 I also get the same error as the OP (with the current repo) Artist Link: https://www.jiosaavn.com/artist/mahendra-kapoor-/mzleuBtK1zU_ Relevant log in my case:
On running it again, the file above got downloaded successfully. After a couple more files, the error happened again:
|
This error is not the same as OP's. You got an error possibly due to connectivity issues. |
Artist page URL : https://www.saavn.com/s/artist/kishore-kumar-albums/yMoPyl3ZzyY_
This happens :
Downloading all Artist songs
Total Songs of the Artist: 12193
Total requests: 1220
Getting Song page: 0
Downloading 1. Bheegi Bheegi Raaton Mein.m4a [*] 4.5 MB / 4.5 MB @ 7.8 MB/s [##################] [100%, 0s left]
..............
Downloading 48. Zindagi Ek Safar.m4a [*] 4.0 MB / 4.0 MB @ 1,013 kB/s [##################] [100%, 0s left]
error() missing 1 required positional argument: 'msg'
No songs found for the artist
DONE
I don't know why, can you give this a look?
The text was updated successfully, but these errors were encountered: