Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted identifiers #10

Open
janusvm opened this issue Aug 24, 2024 · 1 comment
Open

Quoted identifiers #10

janusvm opened this issue Aug 24, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@janusvm
Copy link

janusvm commented Aug 24, 2024

Table and column names in generated SQL currently do not get explicitly quoted, but there are situations where it's necessary.

While you can manually quote identifiers in the string arguments to e.g. from_table and col, wouldn't it make sense to just always quote all identifiers automatically?

@inoas
Copy link
Owner

inoas commented Aug 30, 2024

Table and column names in generated SQL currently do not get explicitly quoted, but there are situations where it's necessary.

While you can manually quote identifiers in the string arguments to e.g. from_table and col, wouldn't it make sense to just always quote all identifiers automatically?

at the moment this falls intentionally to the user.
thing is that it isn't just where.col() but many other places where this would need to be applied.

There used to be a helper function which quoted columns.

I am uncertain what would be the best approach here, do you have an idea?

@inoas inoas added help wanted Extra attention is needed enhancement New feature or request labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants