Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestInterceptor not applied when query executed as stream #105

Open
redfaithful opened this issue Jun 28, 2020 · 1 comment
Open

RequestInterceptor not applied when query executed as stream #105

redfaithful opened this issue Jun 28, 2020 · 1 comment

Comments

@redfaithful
Copy link

redfaithful commented Jun 28, 2020 •
edited
Loading

I tried to use BasicAuthenticationExtension when applying the query as stream, and the header is not added to the query.

In BasicAuthenticationSpec, queries are tested to include the header only with the .execute method and not with .streamAs method. Attached a patch with a scenario testing this issue and failing.
Test_basic_authentication_with_streaming.txt
@redfaithful redfaithful changed the title RequestInterceptors not applied when query executed as stream RequestInterceptor not applied when query executed as stream Jun 28, 2020
@redfaithful
Copy link
Author

Adding a fix to this issue, including the modified test.
Fix_basic_authentication_with_streaming.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@redfaithful