Enable Link-Time Optimization (LTO) #4212
zamazan4ik
started this conversation in
Ideas
Replies: 1 comment
-
A smaller binary would definitely be nice, so we should totally give this a try, but don't expect any miracles performance-wise as Hermes is an almost entirely I/O bound application |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi!
I noticed that in the
Cargo.toml
file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional
dist
orrelease-lto
profile where additionally to regularrelease
optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application withcargo install
, will get the LTO-optimized version "automatically". E.g., checkcargo-outdated
Release profile.Basically, it can be enabled with the following lines:
Thank you.
Beta Was this translation helpful? Give feedback.
All reactions