Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22.
(*TDigest).Quantile()
causes an OOB panic when the digest has been provided with values that, due to floating point arithmetic errors, cause thesort.Search
call to not find ani
such thatt.cumulative[i] >= index
. (Minimal playground reproduction). This PR fixes this bug by clamping access toprocessed.Len()
.Furthermore, the unit tests as written did not pass on my M2 MacBook Pro: due to differences in how the M2 performs floating point math compared to Intel or AMD CPUs, there are small deltas some 14 digits into the results, so
got == tt.expected
evaluates to false:This PR fixes tests on this hardware by updating to a more recent version of gonum and using its
scalar.EqualWithinRel
function to compare floats.