Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log volume and posibility to provide pod annotations #125

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

Nierhoff
Copy link
Contributor

Hi,

I am working with log data collections from infinispan. I have added 2 elements to the helm chart.

  1. A volume dedicated to logs, which can easy be mounted into a sidecar.
  2. Posible to provide custom annotations, this could for example be for opentelemetry injection of sidecar og code level injection.

What do you think ?

Copy link
Collaborator

@rigazilla rigazilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log-volume seems a nice feature but It would be better to not change the default behaviour: could you change to be enabled by the user? maybe via a deploy.container.logVolume option.

pod annotations looks good

@Nierhoff
Copy link
Contributor Author

I have reverted log volume. If it is not a default i would rather implement a generic additional volumes in another PR

@rigazilla rigazilla merged commit 7f7f7ec into infinispan:main Jul 12, 2024
1 check passed
@rigazilla
Copy link
Collaborator

merged thanks @Nierhoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants