Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to process uppercase letters #2

Open
steveatinfincia opened this issue Dec 23, 2016 · 0 comments
Open

Investigate how to process uppercase letters #2

steveatinfincia opened this issue Dec 23, 2016 · 0 comments

Comments

@steveatinfincia
Copy link
Member

BIP0039 says nothing about case.

The fact that validation/checksum fails by default when any letter is uppercase (word lookup fails, wordlists are necessarily lowercase) is a strong suggestion that it's an error to pass uppercase letters at all, but intuitively it seems like it should be case insensitive and should generate the same seed value lowercase would.

bip32-rs doesn't allow seed generation without validating checksums, but if you didn't look at that checksum before proceeding you would get a different seed due to the fact that pbkdf2 will happily eat whatever it is given.

A simple solution would seem to be forcing all phrases to lowercase when validating and generating seeds, but it may be something library consumers should do instead of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant